Clean room cleanup and resume chat in same window#5083
Merged
Conversation
DOsinga
approved these changes
Oct 8, 2025
| if (chat?.messages) { | ||
| setMessages(chat.messages); | ||
| } | ||
| }, [chat?.messages, chat?.sessionId]); |
Collaborator
There was a problem hiding this comment.
this seems good for now, but needs further refactoring I think. I think we should just get rid of useAgent and load the session here from the server - we can add a caching layer to make it look smooth
| toolCallData?.status === 'success' | ||
| ? (toolCallData.value as { name: string; arguments: Record<string, unknown> }) | ||
| : (toolCallData as { name: string; arguments: Record<string, unknown> }); | ||
|
|
Collaborator
There was a problem hiding this comment.
I can see that we need this, but does this work with the old setup? looks vaguely scary
Collaborator
Author
There was a problem hiding this comment.
yes, agreed verified it fixes the issue with the old setup
ui/desktop/src/components/context_management/ContextManager.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary