basecamp2 - Resume chat session from server with a cache#5088
Merged
basecamp2 - Resume chat session from server with a cache#5088
Conversation
zanesq
commented
Oct 9, 2025
| setSessionLoadError(null); | ||
|
|
||
| // Set chat to empty session to indicate loading state | ||
| // todo: set to null instead and handle that in other places |
Collaborator
Author
There was a problem hiding this comment.
I originally set chat to null but it started having cascading effects all over the codebase setting the types to ChatType | null so opted for a less disruptive change for now and figured we can come back to it later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for resuming chat session from server with a cache. Removed reliance on useAgent in Pair2.
Note: this gets us most of the way there but still some rough edges with race conditions from hub (if a session is loaded while the empty chat is still initializing) and improvements to the initial state before loading the chat session.