Set up Datadog metrics for prompt injection detection#5316
Set up Datadog metrics for prompt injection detection#5316dorien-koelemeijer wants to merge 5 commits intoblock:mainfrom
Conversation
crates/goose/src/security/mod.rs
Outdated
| }); | ||
| } else if analysis_result.is_malicious { | ||
| tracing::warn!( | ||
| counter.goose.prompt_injection_finding = 1, |
There was a problem hiding this comment.
you're logging essentially the same thing on 76, 96 and 117 - I think you probably just want to log the same record just with different values; suggest to unify that.
There was a problem hiding this comment.
I think I may leave it as is for now, I'm planning to play around with metrics and logs a bit and will need to determine what will stay and needs to go longer term anyway, so can do one big uplift at that stage
There was a problem hiding this comment.
that arguments rather cuts both ways though; why not simplify it for now while you figure out what you want?
There was a problem hiding this comment.
Fair enough, have cleaned up. Would you mind unblocking the 3 workflows checks below that require approval (I can't unblock these myself)? Thanks!
|
Created #5385 instead (not from forked repo) |
2 participants
Summary
Adding some initial metrics to be consumed in Datadog.
Type of Change
Observability improvement.
Related Issues
Related PR: #4237