Skip to content

Latency issue fix with prepare_inference#535

Merged
zakiali merged 1 commit intov1.0from
zaki/instantiate_token_counter_once
Jan 2, 2025
Merged

Latency issue fix with prepare_inference#535
zakiali merged 1 commit intov1.0from
zaki/instantiate_token_counter_once

Conversation

@zakiali
Copy link
Collaborator

@zakiali zakiali commented Jan 2, 2025

TokenCounter takes about a second to instantiate causing a latency hit every time prepare_infernece is called. This was causing a significant latency hit on every agent interaction. This PR moves that the instantiation to the Agent struct to minimize this hit

@zakiali zakiali force-pushed the zaki/instantiate_token_counter_once branch from 5f7ba9f to 45a48f4 Compare January 2, 2025 23:25
@zakiali zakiali merged commit 4ff588e into v1.0 Jan 2, 2025
4 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

michaelneale added a commit that referenced this pull request Jan 3, 2025
* v1.0:
  [ui]: General ui polish to more closely match designs (#532)
  Latency issue fix with prepare_inference (#535)
  chore: use cross to build binaries (#507)
michaelneale added a commit that referenced this pull request Jan 3, 2025
* v1.0:
  [ui]: Polish and system theme fix (#533)
  [ui]: General ui polish to more closely match designs (#532)
  Latency issue fix with prepare_inference (#535)
  chore: use cross to build binaries (#507)
michaelneale added a commit that referenced this pull request Jan 6, 2025
* v1.0: (43 commits)
  feat: openrouter provider (#538)
  [ui] chore: tidy up gui providers (#537)
  [ui]: Polish and system theme fix (#533)
  [ui]: General ui polish to more closely match designs (#532)
  Latency issue fix with prepare_inference (#535)
  chore: use cross to build binaries (#507)
  feat: a system for non developers to augment developer system (#524)
  fix: Broken open directory and new session buttons in more menu (#520)
  refactor: move get_usage to provider trait (#506)
  fix: Make stop button more obvious (#516)
  fix: Enhance Dark mode menu dots visibility (#517)
  working on automating release of .zip and binaries and having them on each PR as well (#509)
  conditionally load memory system in goose server (#508)
  Adds 'instructions' field to InitializeResult (#511)
  feat: MCP client sdk (#505)
  Update cli-release.yml
  feat: added groq provider (#494)
  fix: use rust tls (#500)
  fix: Ldelalande/fix scroll (#504)
  feat: MCP server sdk (simple version first) (#499)
  ...
@yingjiehe-xyz yingjiehe-xyz deleted the zaki/instantiate_token_counter_once branch February 5, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants