Skip to content

Fix: Compaction client <-> server sync #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katzdave merged 2 commits into from
Oct 30, 2025
Merged

Fix: Compaction client <-> server sync #5481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f488311
fix currentMessages clobber
katzdave Oct 30, 2025
bfd9e30
rm temporal service again...?
katzdave Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/desktop/src/hooks/useChatStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ async function streamFromResponse(
}
case 'UpdateConversation': {
log.messages('conversation-update', event.conversation.length);
// WARNING: Since Message handler uses this local variable, we need to update it here to avoid the client clobbering it.
// Longterm fix is to only send the agent the new messages, not the entire conversation.
currentMessages = event.conversation;
updateMessages(event.conversation);
break;
Expand Down
3 changes: 3 additions & 0 deletions ui/desktop/src/hooks/useMessageStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,9 @@ export function useMessageStream({
}

case 'UpdateConversation': {
// WARNING: Since Message handler uses this local variable, we need to update it here to avoid the client clobbering it.
// Longterm fix is to only send the agent the new messages, not the entire conversation.
currentMessages = parsedEvent.conversation;
setMessages(parsedEvent.conversation);
break;
}
Expand Down
Loading