Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the release workflow by directly updating the OpenAPI schema version field instead of regenerating the entire schema. This avoids the need for a full Rust build and TypeScript SDK generation during release preparation, delegating type regeneration to the standard CI pipeline.
- Adds direct JSON manipulation with
jqto update only the version field in openapi.json - Ensures trailing newline consistency in generated schema files
- Updates diff check to ignore whitespace changes
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/check-openapi-schema.sh | Adds --ignore-space-change flag to git diff for more lenient whitespace comparison |
| crates/goose-server/src/bin/generate_schema.rs | Ensures generated schema file ends with a newline for consistency |
| Justfile | Replaces full schema regeneration with targeted version update using jq, and introduces set-openapi-version recipe |
DOsinga
approved these changes
Nov 11, 2025
tlongwell-block
added a commit
that referenced
this pull request
Nov 12, 2025
* origin/main: (29 commits) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676) fix : action icons overlap session title in chat history (#5684) Document recent goose PRs (#5683) docs: add GOOSE_PATH_ROOT environment variable documentation (#5678) feat: SessionManager integration for acp sessions (#5657) teach copilot our CI (#5672) bump openapi version directly (#5674) governance: update MAINTAINERS.md to reflect new maintainers (#5675) chore: upgrade rmcp to 0.8.5 (#5673) Update release instructions (#5662) Swapped out to_string_lossy with display for user facing text (#5666) ...
Surendhar-N-D
pushed a commit
to Surendhar-N-D/goose
that referenced
this pull request
Nov 17, 2025
arul-cc
pushed a commit
to arul-cc/goose
that referenced
this pull request
Nov 17, 2025
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Blair Allan <Blairallan@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the release branch workflow, we need to bump the openapi version. Doing so by regenerating the schema means doing a rust build plus installing the open-api-ts packages that generate our sdk. But we only want to bump the version -- the usual CI pipeline should handle the type regeneration.