feat: ActionRequired by alexhancock · Pull Request #5897 · block/goose

alexhancock · 2025-11-26T21:32:35Z

Changing the way tool confirmation requests work to be powered by a more generalized "action required" infrastructure which will scale to other use-cases.

No user facing changes for desktop or CLI. Just reorganizing code.

The next thing that will use this is MCP elicitation support, which I have started in df0bd2f and I have seen enough to know this "action required" system is a good foundation.

Copilot

Pull request overview

This PR refactors the tool confirmation system to use a more generalized "ActionRequired" infrastructure that can scale to support additional use cases beyond tool confirmations (such as MCP elicitation support mentioned in the description). The core change replaces ToolConfirmationRequest with a new ActionRequired type that wraps specific action types using a discriminated union pattern with actionType field. Both types are maintained in the MessageContent enum for backwards compatibility during the transition.

Key Changes:

Introduced ActionRequired and ActionRequiredData types with actionType discriminator for extensibility
Migrated tool confirmation requests to use the new ActionRequired infrastructure
Created new /action-required/tool-confirmation endpoint replacing /confirm
Updated all provider format functions to handle both legacy and new message content types

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`ui/desktop/src/types/message.ts`	Updated type imports and filtering logic to work with ActionRequired type
`ui/desktop/src/components/ToolCallConfirmation.tsx`	Updated component to accept ActionRequired instead of ToolConfirmationRequest
`ui/desktop/src/components/GooseMessage.tsx`	Updated to use confirmToolAction API with new data structure
`ui/desktop/src/api/types.gen.ts`	Added ActionRequired types and ConfirmToolActionRequest, removed PermissionConfirmationRequest
`ui/desktop/src/api/sdk.gen.ts`	Added confirmToolAction function, removed confirmPermission function
`ui/desktop/openapi.json`	Added new endpoint schema and ActionRequired types to OpenAPI spec
`crates/goose/src/providers/formats/*.rs`	Updated all provider format functions to skip both legacy and new action required messages
`crates/goose/src/conversation/message.rs`	Added ActionRequired and ActionRequiredData types, updated helper methods
`crates/goose/src/context_mgmt/mod.rs`	Added format handling for ActionRequired in context compaction
`crates/goose/src/agents/tool_execution.rs`	Changed to use with_action_required instead of with_tool_confirmation_request
`crates/goose-server/src/routes/reply.rs`	Removed confirm_permission endpoint and route
`crates/goose-server/src/routes/mod.rs`	Added action_required module to route configuration
`crates/goose-server/src/routes/action_required.rs`	New module with confirm_tool_action endpoint and request types
`crates/goose-server/src/openapi.rs`	Updated OpenAPI documentation to include new types and endpoint
`crates/goose-cli/src/session/output.rs`	Added rendering support for ActionRequired messages
`crates/goose-cli/src/session/mod.rs`	Updated to extract tool confirmation from ActionRequired messages
`crates/goose-cli/src/session/export.rs`	Added export formatting for ActionRequired messages

Copilot · 2025-11-26T21:36:29Z

ui/desktop/src/components/GooseMessage.tsx

-                id: toolConfirmationContent.id,
-                action: 'deny',
+                sessionId,
+                action: "approve",


The action value "approve" is not handled by the backend. The backend's confirm_tool_action function only recognizes "always_allow", "allow_once", and "deny" (lines 39-44 in action_required.rs). An unrecognized action like "approve" will default to "deny", causing the opposite behavior of what's intended. This should be "deny" to cancel the tool when the message is cancelled.

Suggested change

action: "approve",

action: "deny",

Copilot · 2025-11-26T21:36:30Z

ui/desktop/src/types/message.ts

@@ -44,10 +44,10 @@ export function getToolResponses(message: Message): (ToolResponse & { type: 'too

 export function getToolConfirmationContent(


Function name getToolConfirmationContent should be renamed to reflect that it now returns ActionRequired type, not ToolConfirmationRequest. Consider renaming to getActionRequiredContent or similar for clarity.

Suggested change

export function getToolConfirmationContent(

export function getActionRequiredContent(

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

crates/goose/src/conversation/message.rs

ui/desktop/src/components/GooseMessage.tsx

michaelneale · 2025-12-01T21:33:14Z

nice @alexhancock, in this case was the copilot feedback on the money?

michaelneale · 2025-12-01T21:56:28Z

crates/goose/src/providers/formats/anthropic.rs

                    // Skip tool confirmation requests
                }
+                MessageContent::ActionRequired(_action_required) => {
+                    // Skip action required messages - they're for UI only


this one ignores but other one like bedrock returns a value - expected to be different?

will look later tonight

The bedrock one is more about what the provider gets as content in those cases I believe. It doesn't have any meaningful content either way so I will keep with the pattern in each file matching what ToolConfirmationRequest did in each format.

michaelneale

tentative approve to not get in the way - just questions aorund what is in the providers and what is needed there and consistency etc.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

crates/goose-server/src/routes/action_required.rs

* 'main' of github.com:block/goose: chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938) docs: promote planning guide (#5934) fix: use a lock to ensure only need to run tunnel just in case multiple go… (#5885)

@goose

…0-5147 * 'main' of github.com:block/goose: (243 commits) chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938) docs: promote planning guide (#5934) fix: use a lock to ensure only need to run tunnel just in case multiple go… (#5885) Feat: Added custom headers and toggle keyring CLI options (#5017) Feat/automatic update installation (#5345) fix: Added "Merged consecutive assistant messages" to the acceptable issues for moim injection check (#5933) fix: anthropic provider model fetching (#5932) [MCP-UI] add CSP for images to proxy HTML (#5931) fix: correct typo in blog post (AIMDOEL -> AIMODEL) (#5902) feat: @goose in terminal (native terminal support) (#5887) docs: adding AI-friendly features (#5918) Blog/advent of ai announcement (#5917) Extension selector behind ALPHA flag (#5892) blog: typo fixes (#5896) blog: fixing img url (#5895) blog: MCPs for Developers (#5884) docs: Extension Manager MCP (#5883) ... # Conflicts: # crates/goose-server/src/routes/config_management.rs # crates/goose/src/providers/mod.rs # ui/desktop/openapi.json # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/api/types.gen.ts # ui/desktop/src/components/ProgressiveMessageList.tsx

* origin/main: Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) added sidebar contextual information for firefox (#5433) docs: council of mine MCP (#5979) docs: nano banana extension (#5977) fix: remove prompt change, read model from config (#5976) Enable recipe deeplink parameters for pre-population (#5757) chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938) docs: promote planning guide (#5934)

…nses-streaming * 'main' of github.com:block/goose: blog: MCP Sampling (#5987) Update Anthropic and Google Gemini models to latest API versions (#5980) docs: chat recall tutorial (#5975) fix: `final assistant content cannot end with trailing whitespace` error from Anthropic (#5967) 5527 multiple file popups (#5905) Groq configure fix (#5833) added sidebar contextual information for firefox (#5433) docs: council of mine MCP (#5979) docs: nano banana extension (#5977) fix: remove prompt change, read model from config (#5976) Enable recipe deeplink parameters for pre-population (#5757) chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938)

alexhancock requested review from DOsinga, Copilot, jamadeo and michaelneale November 26, 2025 21:32

Copilot started reviewing on behalf of alexhancock November 26, 2025 21:33 View session

Copilot finished reviewing on behalf of alexhancock November 26, 2025 21:35

Copilot AI reviewed Nov 26, 2025

View reviewed changes

alexhancock force-pushed the alexhancock/action-required branch 2 times, most recently from 45b00a9 to d21ccb7 Compare December 1, 2025 15:04

Copilot AI review requested due to automatic review settings December 1, 2025 15:04

Copilot started reviewing on behalf of alexhancock December 1, 2025 15:04 View session

Copilot finished reviewing on behalf of alexhancock December 1, 2025 15:08

Copilot AI reviewed Dec 1, 2025

View reviewed changes

crates/goose/src/conversation/message.rs Show resolved Hide resolved

ui/desktop/src/components/GooseMessage.tsx Outdated Show resolved Hide resolved

alexhancock force-pushed the alexhancock/action-required branch from d21ccb7 to ca2da84 Compare December 1, 2025 15:20

michaelneale reviewed Dec 1, 2025

View reviewed changes

michaelneale approved these changes Dec 1, 2025

View reviewed changes

feat: ActionRequired

5d382f5

Copilot AI review requested due to automatic review settings December 2, 2025 16:09

alexhancock force-pushed the alexhancock/action-required branch from ca2da84 to 5d382f5 Compare December 2, 2025 16:09

Copilot started reviewing on behalf of alexhancock December 2, 2025 16:10 View session

Copilot finished reviewing on behalf of alexhancock December 2, 2025 16:11

Copilot AI reviewed Dec 2, 2025

View reviewed changes

crates/goose-server/src/routes/action_required.rs Show resolved Hide resolved

crates/goose-server/src/routes/action_required.rs Show resolved Hide resolved

alexhancock merged commit 131c7e7 into main Dec 2, 2025
20 of 21 checks passed

alexhancock deleted the alexhancock/action-required branch December 2, 2025 16:48

github-actions bot mentioned this pull request Dec 4, 2025

chore(release): release version 1.16.0 (minor) #5985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ActionRequired#5897

feat: ActionRequired#5897
alexhancock merged 1 commit intomainfrom
alexhancock/action-required

alexhancock commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 26, 2025

Uh oh!

Copilot AI Nov 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

michaelneale commented Dec 1, 2025

Uh oh!

michaelneale Dec 1, 2025

Uh oh!

alexhancock Dec 1, 2025

Uh oh!

alexhancock Dec 2, 2025

Uh oh!

michaelneale left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -44,10 +44,10 @@ export function getToolResponses(message: Message): (ToolResponse & { type: 'too

		export function getToolConfirmationContent(

	export function getToolConfirmationContent(
	export function getActionRequiredContent(

Conversation

alexhancock commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

michaelneale commented Dec 1, 2025

Uh oh!

michaelneale Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

alexhancock Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

alexhancock Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants