fix: update BufReader capacity to 2MB #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice find! |
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
michaelneale
added a commit
that referenced
this pull request
Jan 15, 2025
* ldelalande/welcome-ux-update: (42 commits) format Use new configuration and secret storage Simplify configuration (#607) [setup] UX simplification for adding API keys on app startup adding in comments for where to add variables for bundling can reset the provider will open new window when set show window based on local storage goose_provider update the icon new goose modals for adding models latest changes with mock keystore initial static setup fix: update BufReader capacity to 2MB (#605) fix: escape double quotes in error part (#602) refactor: remove unused errors in mcp-client (#598) add more context from mcp server errors (#599) fix: error formatting for vercel data format (#597) feat: Add endpoint to store secrets in keychain (#595) feat: mcp server prompts (#562) fix: Temporarily disable moderation (#594) ...
salman1993
added a commit
that referenced
this pull request
Jan 16, 2025
* origin/v1.0: feat: add a truncating agent (#579) feat: Release devtools opening keyboard shortcut when goose window is not focused (#614) feat: performance tweaks for partial release (#611) Alexhancock/inline code (#612) feat: add more tracing logs, trim loaded prompt (#603) feature: new welcome page and real keychain (#604) fix: model names in UI API key warning (#609) feat: map non-ok responses from provider to human readable error msgs (#610) fix: update BufReader capacity to 2MB (#605) fix: escape double quotes in error part (#602) refactor: remove unused errors in mcp-client (#598) add more context from mcp server errors (#599) fix: error formatting for vercel data format (#597) feat: Add endpoint to store secrets in keychain (#595)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase BufReader capacity
This increases the BufReader's capacity to
2 * 1024 * 1024(2MB) to handle very large message sizes.With the default of
8 * 1024(https://doc.rust-lang.org/std/io/struct.BufReader.html) we saw truncated json-rpc messages coming across to the mcp-server.couldn't have figured this out without @salman1993, thanks for all the help!