fix(install script): ensure script works when piped into bash#6296
Merged
michaelneale merged 1 commit intoblock:mainfrom Jan 5, 2026
Merged
fix(install script): ensure script works when piped into bash#6296michaelneale merged 1 commit intoblock:mainfrom
michaelneale merged 1 commit intoblock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the download_cli.sh installation script to work correctly when piped into bash (e.g., curl ... | bash). Previously, the read command would fail because stdin was the script itself rather than the terminal, preventing the script from waiting for user input when asking whether to add the goose bin directory to PATH.
- Adds conditional logic to detect if stdin is a terminal and reads from
/dev/ttywhen it's not
Fixes block#6295 Signed-off-by: Irbe Krumina <irbekrm@gmail.com>
irbekrm
force-pushed
the
irbekrm/fix_install_script
branch
from
82e1b3d to
33e5425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
download_cli.shinstallation script to work correctly when piped into bash (e.g., curl ... | bash), such as suggested by the Goose CLI install instructions. Previously, the read command would fail because stdin was the script itself rather than the terminal, preventing the script from waiting for user input when asking whether to add the goose bin directory to PATH.The approach is similar to rustup script
Type of Change
AI Assistance
Testing
I have manually tested that with this change the script succeeds when piped into bash (which was not working previously) as well as still works when ran directly on both Mac and Linux.
Related Issues
Relates to #6295
Screenshots/Demos (for UX changes)
Before:
Details
After:
Details