Skip to content

changed z-index to make sure the search highlighter does not appear on modal overlay#6386

Merged
lifeizhou-ap merged 1 commit intomainfrom
lifei/remove-search-highlight-in-edit-recipe
Jan 7, 2026
Merged

changed z-index to make sure the search highlighter does not appear on modal overlay#6386
lifeizhou-ap merged 1 commit intomainfrom
lifei/remove-search-highlight-in-edit-recipe

Conversation

@lifeizhou-ap
Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap commented Jan 7, 2026 •
edited
Loading

Summary

  • Step to produce the bug

    • In recipe list, search by some keyword. You can see the keywords are highlighted in the list
    • Select a recipe and click the edit button, the edit recipe modal appears. The highlights are still shown in the modal.

  • Expected behaviour
    The highlights should not be shown in the modal.

  • Fix
    Currently no search highlighter is used in any modal. So changed the z-index for Search Highlighter to 1 will fix. Therefore the highlight still appears on the main page but not the modal overlay.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Manual testing

Screenshots/Demos (for UX changes)

Before:
Screenshot 2026-01-08 at 9 06 28 am

After:
Screenshot 2026-01-08 at 9 45 34 am

Copilot AI review requested due to automatic review settings January 7, 2026 22:46
Copilot AI reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a z-index layering issue where the search highlighter overlay was appearing on top of modal dialogs. The z-index was reduced from 9999 to 1, ensuring the search highlights remain below modal overlays (z-40) and dialog content (z-50) while still appearing above normal page content.

Key Changes

  • Reduced search highlighter overlay z-index from 9999 to 1 to fix visual stacking order

@lifeizhou-ap lifeizhou-ap merged commit 4227165 into main Jan 7, 2026
23 checks passed
@lifeizhou-ap lifeizhou-ap deleted the lifei/remove-search-highlight-in-edit-recipe branch January 7, 2026 23:01
zanesq added a commit that referenced this pull request Jan 8, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into zane/working-dir
08fd418 
* 'main' of github.com:block/goose:
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374)
@lifeizhou-ap lifeizhou-ap restored the lifei/remove-search-highlight-in-edit-recipe branch January 8, 2026 21:36
michaelneale added a commit that referenced this pull request Jan 8, 2026
@michaelneale
Merge branch 'main' into micn/http-proxy
75b60db 
* main: (31 commits)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  fix: prevent infinite loop of tool-input notifications in MCP Apps (#6374)
  fix: Show platform-specific keyboard shortcuts in UI (#6323)
  fix: we load extensions when agent starts so don't do it up front (#6350)
  docs: credit HumanLayer in RPI tutorial (#6365)
  Blog: Goose Lands MCP Apps (#6172)
  Claude 3.7 is out. we had some harcoded stuff (#6197)
  ...
wpfleger96 added a commit that referenced this pull request Jan 9, 2026
@wpfleger96
Merge branch 'main' into wpfleger/fork-session
b4105b9 
* main: (89 commits)
  fix(google): treat signed text as regular content in streaming (#6400)
  Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399)
  fix(ci): add missing dependencies to openapi-schema-check job (#6367)
  feat: http proxy support
  Add support for changing working dir and extensions in same window/session (#6057)
  Sort keys in canonical models (#6403)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  ...
wpfleger96 added a commit that referenced this pull request Jan 9, 2026
@wpfleger96
Merge branch 'main' into wpfleger/fork-session
1b9cf6f 
* main: (89 commits)
  fix(google): treat signed text as regular content in streaming (#6400)
  Add frameDomains and baseUriDomains CSP support for MCP Apps (#6399)
  fix(ci): add missing dependencies to openapi-schema-check job (#6367)
  feat: http proxy support
  Add support for changing working dir and extensions in same window/session (#6057)
  Sort keys in canonical models (#6403)
  added validation and debug for invalid call tool result (#6368)
  Update MCP apps tutorial: fix _meta structure and version prereq (#6404)
  Fixed fonts (#6389)
  Update confidence levels prompt injection detection to reduce false positive rates (#6390)
  Add ML-based prompt injection detection  (#5623)
  docs: update custom extensions tutorial (#6388)
  fix ResultsFormat error when loading old sessions (#6385)
  docs: add MCP Apps tutorial and documentation updates (#6384)
  changed z-index to make sure the search highlighter does not appear on modal overlay (#6386)
  Handling special claude model response in github copilot provider (#6369)
  fix: prevent duplicate rendering when tool returns both mcp-ui and mcp-apps resources (#6378)
  fix: update MCP Apps _meta.ui.resourceUri to use nested format (SEP-1865) (#6372)
  feat(providers): add streaming support for Google Gemini provider (#6191)
  Blog: edit links in mcp apps post (#6371)
  ...
@github-actions github-actions bot mentioned this pull request Jan 13, 2026
Merged
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
@lifeizhou-ap @fbalicchia
changed z-index to make sure the search highlighter does not appear o…
2526130 
…n modal overlay (block#6386)
@lifeizhou-ap lifeizhou-ap deleted the lifei/remove-search-highlight-in-edit-recipe branch January 27, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@zanesq zanesq zanesq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lifeizhou-ap @zanesq