Skip to content

Restore task completion notification#6427

Merged
blackgirlbytes merged 1 commit intomainfrom
restore-task-completion-notification
Jan 9, 2026
Merged

Restore task completion notification#6427
blackgirlbytes merged 1 commit intomainfrom
restore-task-completion-notification

Conversation

@blackgirlbytes
Copy link
Contributor

Summary

Restores the task completion notification that was accidentally removed in PR #5706.

When Goose finishes a task and more than 60 seconds have passed since the user's last interaction, a notification is shown to alert them that the task is complete.

Changes

  • Added lastInteractionTimeRef to track when user last interacted
  • Updated handleSubmit to record interaction time when user sends a message
  • Updated submitElicitationResponse to record interaction time when user responds to elicitation
  • Updated stopStreaming to record interaction time when user stops Goose
  • Added notification logic in onFinish callback - shows notification if >60 seconds since last interaction

Testing

  • TypeScript compiles without errors
  • ESLint passes
  • Behavior matches the original implementation from the removed useChatEngine.ts

Copilot AI review requested due to automatic review settings January 9, 2026 22:48
@blackgirlbytes blackgirlbytes force-pushed the restore-task-completion-notification branch 2 times, most recently from 977c05c to 3a2a26a Compare January 9, 2026 22:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores the task completion notification feature that was accidentally removed in PR #5706. The notification appears when goose finishes a task and more than 60 seconds have passed since the user's last interaction.

Key Changes

  • Added tracking of user interaction time via lastInteractionTimeRef
  • Updated interaction tracking in three locations: message submission, elicitation responses, and stream stopping
  • Added notification logic in the onFinish callback to show notifications after 60-second idle periods

Restores the notification that was accidentally removed in PR #5706.
When Goose finishes a task and more than 60 seconds have passed since
the user's last interaction, a notification is shown to alert them.

The last interaction time is tracked when:
- User submits a message
- User responds to an elicitation
- User stops Goose
@blackgirlbytes blackgirlbytes force-pushed the restore-task-completion-notification branch from 3a2a26a to f7f8e34 Compare January 9, 2026 23:24
@blackgirlbytes blackgirlbytes merged commit 40747eb into main Jan 9, 2026
18 checks passed
@blackgirlbytes blackgirlbytes deleted the restore-task-completion-notification branch January 9, 2026 23:44
zanesq added a commit that referenced this pull request Jan 12, 2026
…ased

* 'main' of github.com:block/goose:
  chore: break up process agent response (#6348)
  More 3.7 removal (#6414)
  CLI show extension errors (#6398)
  fix[desktop]: Improve UX for ExtensionItem component (#6443)
  update[doc]: Add tip for GitHub Copilot Provider (#6441)
  Avoid using cliclack.confirm in non-interactive session (#6412)
  docs: claude prompt caching note (#6429)
  Restore task completion notification (#6427)
  docs: stream-json and auth-token cli options (#6426)
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants