Restore task completion notification#6427
Merged
blackgirlbytes merged 1 commit intomainfrom Jan 9, 2026
Merged
Conversation
977c05c to
3a2a26a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the task completion notification feature that was accidentally removed in PR #5706. The notification appears when goose finishes a task and more than 60 seconds have passed since the user's last interaction.
Key Changes
- Added tracking of user interaction time via
lastInteractionTimeRef - Updated interaction tracking in three locations: message submission, elicitation responses, and stream stopping
- Added notification logic in the
onFinishcallback to show notifications after 60-second idle periods
3 tasks
Restores the notification that was accidentally removed in PR #5706. When Goose finishes a task and more than 60 seconds have passed since the user's last interaction, a notification is shown to alert them. The last interaction time is tracked when: - User submits a message - User responds to an elicitation - User stops Goose
3a2a26a to
f7f8e34
Compare
The-Best-Codes
approved these changes
Jan 9, 2026
zanesq
added a commit
that referenced
this pull request
Jan 12, 2026
…ased * 'main' of github.com:block/goose: chore: break up process agent response (#6348) More 3.7 removal (#6414) CLI show extension errors (#6398) fix[desktop]: Improve UX for ExtensionItem component (#6443) update[doc]: Add tip for GitHub Copilot Provider (#6441) Avoid using cliclack.confirm in non-interactive session (#6412) docs: claude prompt caching note (#6429) Restore task completion notification (#6427) docs: stream-json and auth-token cli options (#6426)
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 13, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the task completion notification that was accidentally removed in PR #5706.
When Goose finishes a task and more than 60 seconds have passed since the user's last interaction, a notification is shown to alert them that the task is complete.
Changes
lastInteractionTimeRefto track when user last interactedhandleSubmitto record interaction time when user sends a messagesubmitElicitationResponseto record interaction time when user responds to elicitationstopStreamingto record interaction time when user stops GooseonFinishcallback - shows notification if >60 seconds since last interactionTesting
useChatEngine.ts