Skip to content

allow --with-builtin extension on cli resume #6502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Evanfeenstra wants to merge 2 commits into from
Closed

allow --with-builtin extension on cli resume #6502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8355c3a
allow --with-builtin extension on cli resume
Evanfeenstra Jan 14, 2026
433916c
rename var to cli_builtin_names
Evanfeenstra Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/goose-cli/src/session/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,16 @@ async fn offer_extension_debugging_help(
Ok(())
}

fn check_missing_extensions_or_exit(saved_extensions: &[ExtensionConfig], interactive: bool) {
fn check_missing_extensions_or_exit(
saved_extensions: &[ExtensionConfig],
cli_builtin_names: &HashSet<String>,
interactive: bool,
) {
let missing: Vec<_> = saved_extensions
.iter()
.filter(|ext| get_extension_by_name(&ext.name()).is_none())
.filter(|ext| {
!cli_builtin_names.contains(&ext.name()) && get_extension_by_name(&ext.name()).is_none()
})
.cloned()
.collect();

Expand Down Expand Up @@ -447,6 +453,9 @@ pub async fn build_session(session_config: SessionBuilderConfig) -> CliSession {
eprintln!("{}", style(format!("Warning: {}", warning)).yellow());
}

// Collect CLI-provided builtin names to avoid false "missing" warnings on resume
let cli_builtin_names: HashSet<String> = session_config.builtins.iter().cloned().collect();

// If we get extensions_override, only run those extensions and none other
let extensions_to_run: Vec<_> = if let Some(extensions) = session_config.extensions_override {
extensions.into_iter().collect()
Expand All @@ -458,6 +467,7 @@ pub async fn build_session(session_config: SessionBuilderConfig) -> CliSession {
{
check_missing_extensions_or_exit(
&saved_state.extensions,
&cli_builtin_names,
session_config.interactive,
);
saved_state.extensions
Expand Down
Loading