feat(cli): allow custom timeout for streamable HTTP extensions#6521
Closed
Jazzcort wants to merge 1 commit intoblock:mainfrom
Closed
feat(cli): allow custom timeout for streamable HTTP extensions#6521Jazzcort wants to merge 1 commit intoblock:mainfrom
Jazzcort wants to merge 1 commit intoblock:mainfrom
Conversation
Updates argument parsing to support a `url timeout=<seconds>` format, allowing users to override the default extension timeout. Signed-off-by: Jazzcort <jason101011113@gmail.com>
DOsinga
approved these changes
Jan 28, 2026
Merged
Collaborator
|
I've resolve the merge conflicts in #6772 and will merge that one. thank you! |
Contributor
Author
|
Thank you so much for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates argument parsing to support a
url timeout=<seconds>format, allowing users to override the default extension timeout.Also want to add this feature to
--with-extension(stdio extension), but not sure about what would be the best design of the format since the current format already included envs (Format: "ENV1=val1 ENV2=val2 command args..."). We can either add it at the end (after args...) like what I did for '--with-streamable-http-extension' or having a reserved env likeEXT_TIMEOUT. The first approach might interfere the command if there are some edge cases, the later approach makes the behavior of passing customized timeout not consistent between--with-extensionand--with-streamable-http-extension.Type of Change
AI Assistance
Testing
goose session --with-streamable-http-extension "http://localhost:<port> timeout=<seconds>"Use the above command to add a streamable http extension to the session with a customized timeout other than the default.
Maybe try eprintln!() the config to check if the timeout is successfully parsed.