codex: refine reasoning effort validation#6522
Merged
DOsinga merged 1 commit intoblock:mainfrom Jan 28, 2026
Merged
Conversation
82ad4bf to
080e637
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the reasoning effort validation for the Codex provider by adding support for xhigh and none levels, and implementing model-specific validation where none is only supported on non-codex models (like gpt-5.2).
Changes:
- Added
xhighandnoneto the list of valid reasoning effort levels - Implemented model-specific validation logic via a new
supports_reasoning_efforthelper function - Updated documentation to reflect the new reasoning effort levels (should be removed per project guidelines)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/goose/src/providers/codex.rs | Added supports_reasoning_effort function to validate reasoning levels based on model type; updated constant and comments to include new levels; added comprehensive tests |
| documentation/docs/guides/cli-providers.md | Updated feature descriptions and configuration table to document new reasoning effort levels |
Add 'none' and 'xhigh' to CODEX_REASONING_LEVELS Signed-off-by: Yusuke Shimizu <stm1051212@gmail.com>
080e637 to
0208de1
Compare
9 tasks
michaelneale
approved these changes
Jan 27, 2026
Collaborator
michaelneale
left a comment
There was a problem hiding this comment.
thanks - I think this may fix warnings I saw with things (maybe)
eliasposen
pushed a commit
to eliasposen/goose
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Yusuke Shimizu <stm1051212@gmail.com> Signed-off-by: Elias Posen <elias@posen.ch>
9 tasks
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine Codex provider reasoning-effort validation and expand supported
CODEX_REASONING_EFFORTvalues to includexhighandnone. Add model-aware validation sononeis rejected for*-codexmodels (falls back tohighwith a warning).I will handle documentation updates in a separate PR, in accordance with the policy.
Type of Change
AI Assistance
Testing
GitHub Actions (Build and Test Rust Project).
Related Issues
Relates to: N/A
Discussion: N/A
Screenshots/Demos (for UX changes)
Before: N/A
After: N/A