Skip to content

codex: refine reasoning effort validation#6522

Merged
DOsinga merged 1 commit intoblock:mainfrom
YusukeShimizu:codex-reasoning-levels
Jan 28, 2026
Merged

codex: refine reasoning effort validation#6522
DOsinga merged 1 commit intoblock:mainfrom
YusukeShimizu:codex-reasoning-levels

Conversation

@YusukeShimizu
Copy link
Contributor

@YusukeShimizu YusukeShimizu commented Jan 15, 2026

Summary

Refine Codex provider reasoning-effort validation and expand supported CODEX_REASONING_EFFORT values to include xhigh and none. Add model-aware validation so none is rejected for *-codex models (falls back to high with a warning).

I will handle documentation updates in a separate PR, in accordance with the policy.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

GitHub Actions (Build and Test Rust Project).

Related Issues

Relates to: N/A
Discussion: N/A

Screenshots/Demos (for UX changes)

Before: N/A
After: N/A

@YusukeShimizu YusukeShimizu force-pushed the codex-reasoning-levels branch from 82ad4bf to 080e637 Compare January 18, 2026 03:57
@YusukeShimizu YusukeShimizu marked this pull request as ready for review January 18, 2026 04:06
@YusukeShimizu YusukeShimizu requested a review from a team as a code owner January 18, 2026 04:06
Copilot AI review requested due to automatic review settings January 18, 2026 04:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the reasoning effort validation for the Codex provider by adding support for xhigh and none levels, and implementing model-specific validation where none is only supported on non-codex models (like gpt-5.2).

Changes:

  • Added xhigh and none to the list of valid reasoning effort levels
  • Implemented model-specific validation logic via a new supports_reasoning_effort helper function
  • Updated documentation to reflect the new reasoning effort levels (should be removed per project guidelines)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/goose/src/providers/codex.rs Added supports_reasoning_effort function to validate reasoning levels based on model type; updated constant and comments to include new levels; added comprehensive tests
documentation/docs/guides/cli-providers.md Updated feature descriptions and configuration table to document new reasoning effort levels

Add 'none' and 'xhigh' to CODEX_REASONING_LEVELS

Signed-off-by: Yusuke Shimizu <stm1051212@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@zanesq zanesq requested a review from michaelneale January 26, 2026 23:39
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - I think this may fix warnings I saw with things (maybe)

@DOsinga DOsinga merged commit 18d6db4 into block:main Jan 28, 2026
24 checks passed
eliasposen pushed a commit to eliasposen/goose that referenced this pull request Jan 28, 2026
Signed-off-by: Yusuke Shimizu <stm1051212@gmail.com>
Signed-off-by: Elias Posen <elias@posen.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants