fix: prevent docs deploy from being cancelled by PR previews#6553
Merged
angiejones merged 1 commit intomainfrom Jan 17, 2026
Merged
fix: prevent docs deploy from being cancelled by PR previews#6553angiejones merged 1 commit intomainfrom
angiejones merged 1 commit intomainfrom
Conversation
The deploy workflow was using the same concurrency group as PR previews but without cancel-in-progress: false, which meant production deploys could be cancelled when a PR preview triggered at the same time. This caused PR #6547 to not deploy despite being merged. Setting cancel-in-progress: false ensures production deploys will queue and wait rather than being cancelled.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a deployment issue where production documentation deploys were being cancelled when PR preview workflows triggered simultaneously. The fix ensures production deploys queue and wait rather than being cancelled, while still preventing race conditions on the gh-pages branch.
Changes:
- Add
cancel-in-progress: falseto the production deploy workflow's concurrency configuration
angiejones
approved these changes
Jan 17, 2026
raj-subhankar
pushed a commit
to raj-subhankar/goose
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #6547 was merged but never deployed to the blog site. The deployment workflow was cancelled because it triggered at the same time as a PR preview workflow.
Both workflows share the
concurrency: pr-previewgroup to prevent race conditions when writing to gh-pages. However, withoutcancel-in-progress: false, production deploys can be cancelled by PR previews.Solution
Add
cancel-in-progress: falseto the deploy workflow. This ensures:Testing
This is a workflow configuration change. The behavior can be verified by: