fix(1785): enable lto and codegen-units in release build#6586
Merged
jh-block merged 1 commit intoblock:mainfrom Feb 4, 2026
Merged
fix(1785): enable lto and codegen-units in release build#6586jh-block merged 1 commit intoblock:mainfrom
jh-block merged 1 commit intoblock:mainfrom
Conversation
Signed-off-by: lsytj0413 <511121939@qq.com>
Contributor
Author
|
@michaelneale could you please take a look at this pr？ |
Contributor
Author
|
@lifeizhou-ap could you please take a look at this pr？ |
jh-block
reviewed
Feb 4, 2026
|
|
||
| [profile.release] | ||
| codegen-units = 1 | ||
| lto = true |
Collaborator
There was a problem hiding this comment.
Thanks for the contribution, it will be good to have a more optimised release build. I think it would be better to use lto = "thin" here, what do you think? ThinLTO achieves optimisation results very close to "fat" LTO but with substantially less build time penalty
Collaborator
There was a problem hiding this comment.
Actually, I see in the linked issue that all three were compared and fat LTO is doing better at reducing binary size. I'll merge this as-is for now and if build times become an issue we can revisit. Thanks again!
jh-block
approved these changes
Feb 4, 2026
stebbins
pushed a commit
to stebbins/goose
that referenced
this pull request
Feb 4, 2026
Signed-off-by: lsytj0413 <511121939@qq.com> Signed-off-by: Harrison <hcstebbins@gmail.com>
jamadeo
added a commit
that referenced
this pull request
Feb 5, 2026
…)" This reverts commit 79088db.
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binary size:
build time:
Fix: #1785
Type of Change
AI Assistance
Testing
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: