Skip to content

chore: reduce duplicate or unused cargo deps#6630

Merged
codefromthecrypt merged 1 commit intomainfrom
less-deps
Jan 23, 2026
Merged

chore: reduce duplicate or unused cargo deps#6630
codefromthecrypt merged 1 commit intomainfrom
less-deps

Conversation

@codefromthecrypt
Copy link
Collaborator

Summary

This reduces the amount of duplicate versions in cargo. I started looking at this noticing we are skewed again on rmcp.

Type of Change

  • Build / Release

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

ran tests

Related Issues

raised agentclientprotocol/symposium-acp#117 to get rid of the multiple rmcp versions

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt codefromthecrypt marked this pull request as ready for review January 22, 2026 10:01
Copilot AI review requested due to automatic review settings January 22, 2026 10:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates and deduplicates Cargo dependencies across the workspace, and updates some tests to use the shared env-lock test utility instead of temp-env. The goal is to reduce version skew (especially around rmcp and HTTP-related crates) and clean up unused dev-dependencies.

Changes:

  • Switched several crates (goose, goose-server, goose-mcp, goose-cli, goose-acp) to use workspace-wide versions of reqwest, tower(-http), url, base64, and testing crates like test-case, reducing duplicate versions.
  • Removed unused dev-dependencies such as temp-env, criterion, agent-client-protocol-schema, and others, with corresponding Cargo.lock cleanup.
  • Updated Config tests in crates/goose/src/config/base.rs to use env_lock::lock_env instead of temp_env::with_vars for environment isolation.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/goose/src/config/base.rs Replaced temp_env::with_vars with env_lock::lock_env in three secret-related tests to use the workspace-standard env locking utility.
crates/goose/Cargo.toml Pointed reqwest, base64, and url to workspace dependencies and removed unused dev-deps (agent-client-protocol-schema, criterion, temp-env), keeping feature sets unchanged.
crates/goose-server/Cargo.toml Switched tower-http, base64, reqwest, and url to workspace-managed versions; simplified dev-dependencies by reusing workspace tower and env-lock.
crates/goose-mcp/Cargo.toml Standardized url, base64, and reqwest to workspace versions; removed unused optional utoipa dependency and some unused dev-deps.
crates/goose-cli/Cargo.toml Moved base64 and tower-http to workspace versions and dropped unused dev-deps (temp-env, test-case, serial_test) from this crate.
crates/goose-acp/Cargo.toml Switched url to the workspace version, moved test-case to the workspace dev-dependency, and removed tower-http dev-dep that is no longer used.
Cargo.toml Added workspace-wide entries for test-case, base64, reqwest, tower, tower-http, and url to centralize versions.
Cargo.lock Regenerated to reflect dependency deduplication and removals (e.g., criterion, temp-env, older rustls-native-certs, extra sysinfo, and older tower-http), and to align all consumers with the new unified versions.

@codefromthecrypt codefromthecrypt merged commit 0602dc7 into main Jan 23, 2026
25 checks passed
@codefromthecrypt codefromthecrypt deleted the less-deps branch January 23, 2026 07:27
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 23, 2026
Signed-off-by: Adrian Cole <adrian@tetrate.io>
Signed-off-by: fbalicchia <fbalicchia@cuebiq.com>
tlongwell-block added a commit that referenced this pull request Jan 23, 2026
* origin/main:
  Fix GCP Vertex AI global endpoint support for Gemini 3 models (#6187)
  fix: macOS keychain infinite prompt loop    (#6620)
  chore: reduce duplicate or unused cargo deps (#6630)
  feat: codex subscription support (#6600)
  smoke test allow pass for flaky providers (#6638)
  feat: Add built-in skill for goose documentation reference (#6534)
  Native images (#6619)
  docs: ml-based prompt injection detection (#6627)
  Strip the audience for compacting (#6646)
  chore(release): release version 1.21.0 (minor) (#6634)
  add collapsable chat nav (#6649)
  fix: capitalize Rust in CONTRIBUTING.md (#6640)
  chore(deps): bump lodash from 4.17.21 to 4.17.23 in /ui/desktop (#6623)
  Vibe mcp apps (#6569)
  Add session forking capability (#5882)
  chore(deps): bump lodash from 4.17.21 to 4.17.23 in /documentation (#6624)
  fix(docs): use named import for globby v13 (#6639)
  PR Code Review (#6043)
  fix(docs): use dynamic import for globby ESM module (#6636)

# Conflicts:
#	Cargo.lock
#	crates/goose-server/src/routes/session.rs
katzdave added a commit that referenced this pull request Jan 26, 2026
…o dkatz/canonical-context

* 'dkatz/canonical-provider' of github.com:block/goose: (27 commits)
  docs: add Remotion video creation tutorial (#6675)
  docs: export recipe and copy yaml (#6680)
  Test against fastmcp (#6666)
  docs: mid-session changes (#6672)
  Fix MCP elicitation deadlock and improve UX (#6650)
  chore: upgrade to rmcp 0.14.0 (#6674)
  [docs] add MCP-UI to MCP Apps blog (#6664)
  ACP get working dir from args.cwd (#6653)
  Optimise load config in UI (#6662)
  Fix GCP Vertex AI global endpoint support for Gemini 3 models (#6187)
  fix: macOS keychain infinite prompt loop    (#6620)
  chore: reduce duplicate or unused cargo deps (#6630)
  feat: codex subscription support (#6600)
  smoke test allow pass for flaky providers (#6638)
  feat: Add built-in skill for goose documentation reference (#6534)
  Native images (#6619)
  docs: ml-based prompt injection detection (#6627)
  Strip the audience for compacting (#6646)
  chore(release): release version 1.21.0 (minor) (#6634)
  add collapsable chat nav (#6649)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants