Revert "chore: upgrade rmcp (#6516)"#6665
Merged
jamadeo merged 1 commit intorelease/1.21.1from Jan 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the rmcp dependency upgrade by pinning rmcp back to 0.12.0 and updating the codebase to match the older API surface (notably removing task/tasks fields that existed in the upgraded version).
Changes:
- Downgrade workspace dependency
rmcpfrom0.13.0to0.12.0and updateCargo.lockaccordingly. - Remove
task: NonefromCallToolRequestParamconstruction sites across providers, agents, server routes, examples, and tests. - Remove
tasks: NonefromServerCapabilitiesinitialization for extension clients.
Reviewed changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/goose/tests/repetition_inspector_tests.rs | Remove task field from CallToolRequestParam in tests. |
| crates/goose/tests/providers.rs | Remove task field from tool request param in provider tests. |
| crates/goose/tests/mcp_integration_test.rs | Update integration tests to construct CallToolRequestParam without task. |
| crates/goose/tests/agent.rs | Remove task field from tool call param in agent tests. |
| crates/goose/src/tool_inspection.rs | Remove task field from tool inspection test setup. |
| crates/goose/src/security/security_inspector.rs | Remove task field from security inspector test setup. |
| crates/goose/src/security/scanner.rs | Remove task field from scanner test setup. |
| crates/goose/src/providers/venice.rs | Remove task field from provider tool-call construction. |
| crates/goose/src/providers/toolshim.rs | Remove task field from toolshim tool-call construction. |
| crates/goose/src/providers/formats/snowflake.rs | Remove task field from Snowflake tool-call parsing/tests. |
| crates/goose/src/providers/formats/openai_responses.rs | Remove task field from OpenAI Responses tool request conversion. |
| crates/goose/src/providers/formats/openai.rs | Remove task field from OpenAI format conversions and tests. |
| crates/goose/src/providers/formats/google.rs | Remove task field from Google format tool request construction and tests. |
| crates/goose/src/providers/formats/databricks.rs | Remove task field from Databricks format conversions and tests. |
| crates/goose/src/providers/formats/bedrock.rs | Remove task field from Bedrock tool request conversion. |
| crates/goose/src/providers/formats/anthropic.rs | Remove task field from Anthropic format conversions and tests. |
| crates/goose/src/conversation/tool_result_serde.rs | Remove task field when reconstructing tool call params for serde. |
| crates/goose/src/conversation/mod.rs | Remove task field from conversation tests’ tool request construction. |
| crates/goose/src/conversation/message.rs | Remove task field from message tests’ tool request construction. |
| crates/goose/src/context_mgmt/mod.rs | Remove task field from context management tests. |
| crates/goose/src/agents/todo_extension.rs | Remove tasks field from ServerCapabilities initialization. |
| crates/goose/src/agents/skills_extension.rs | Remove tasks field from ServerCapabilities initialization (including test fixtures). |
| crates/goose/src/agents/moim.rs | Remove task field from tool request params in tests. |
| crates/goose/src/agents/mcp_client.rs | Remove task field from CallToolRequestParam in client call path. |
| crates/goose/src/agents/final_output_tool.rs | Remove task field from final output tool tests. |
| crates/goose/src/agents/extension_manager_extension.rs | Remove tasks field from ServerCapabilities initialization. |
| crates/goose/src/agents/extension_manager.rs | Remove task field from extension manager tests’ tool call params. |
| crates/goose/src/agents/code_execution_extension.rs | Remove tasks field from ServerCapabilities and task from tool-call construction. |
| crates/goose/src/agents/chatrecall_extension.rs | Remove tasks field from ServerCapabilities initialization. |
| crates/goose/src/agents/apps_extension.rs | Remove tasks field from ServerCapabilities initialization. |
| crates/goose/examples/image_tool.rs | Remove task field from example tool request construction. |
| crates/goose-server/src/routes/agent.rs | Remove task field from server-side tool call construction. |
| crates/goose-cli/src/session/export.rs | Remove task field from CLI session export tests’ tool call params. |
| Cargo.toml | Downgrade rmcp dependency to 0.12.0. |
| Cargo.lock | Update lockfile to reflect rmcp 0.12.0 / rmcp-macros 0.12.0 and remove 0.13.0 entries. |
Comment on lines
543
to
547
| let request = ClientRequest::CallToolRequest(CallToolRequest { | ||
| params: CallToolRequestParam { | ||
| task: None, | ||
| name: name.to_string().into(), | ||
| arguments, | ||
| }, |
There was a problem hiding this comment.
After reverting rmcp and removing task from CallToolRequestParam here, this file still builds a CallToolRequestParam with task: None in the test helper call_tool_request (around line 724), which will fail to compile against the reverted type; remove/update that remaining task field as well.
This reverts commit 4191826.
332a236 to
610436b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.