Skip to content

fix: docs workflow cleanup and prevent cancellations#6713

Merged
blackgirlbytes merged 1 commit intomainfrom
fix/docs-workflow-cleanup
Jan 26, 2026
Merged

fix: docs workflow cleanup and prevent cancellations#6713
blackgirlbytes merged 1 commit intomainfrom
fix/docs-workflow-cleanup

Conversation

@blackgirlbytes
Copy link
Contributor

@blackgirlbytes blackgirlbytes commented Jan 26, 2026

Summary

Fixes the docs deployment workflow issues that have been causing failures for months.

Root Causes Found

  1. PR preview cleanup jobs were being cancelled - The pr-website-preview.yml workflow was missing cancel-in-progress: false, so when a PR was merged, the cleanup job would get cancelled by the deploy job (both in the same concurrency group). This caused PR previews to accumulate.

  2. Unnecessary push trigger was wasting CI and causing conflicts - The preview workflow had a push trigger that ran on every push to every branch (except dependabot). This was:

    • Doing nothing useful (deploy step was skipped due to missing PR context)
    • Competing in the concurrency group with legitimate deploy jobs
    • Wasting CI resources

  3. Disk space filled up - The accumulated PR previews (6.5GB) filled up the GitHub Actions runner disk space, causing deploy failures.

Changes

pr-website-preview.yml:

  • Removed the unnecessary push trigger (the pull_request trigger with synchronize already handles PR updates)
  • Added cancel-in-progress: false to match the deploy workflow and prevent cleanup jobs from being cancelled

deploy-docs-and-extensions.yml:

  • Added disk space cleanup step as a safety net

Already Done

  • Manually cleaned up 6.5GB of stale PR previews from gh-pages
  • Re-ran the failed deploy workflow (now passing)

Testing

After this PR merges, the next docs PR that gets merged should:

  1. Have its preview cleaned up properly
  2. Not cause disk space issues

Copilot AI review requested due to automatic review settings January 26, 2026 16:38
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes long-standing docs deployment reliability issues by preventing PR preview cleanup runs from being cancelled and adding a disk-space safety net to the production docs deploy workflow.

Changes:

  • Removed the unnecessary push trigger from the PR docs preview workflow (keeps only pull_request with docs path filtering).
  • Updated PR preview workflow concurrency config to explicitly set cancel-in-progress: false so cleanup runs aren’t cancelled.
  • Added a pre-flight “Free disk space” step to the production docs deploy workflow to reduce runner disk exhaustion failures.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/pr-website-preview.yml Removes redundant trigger and makes concurrency behavior explicit to prevent cleanup cancellation.
.github/workflows/deploy-docs-and-extensions.yml Adds runner disk cleanup step ahead of the docs build/deploy to reduce failures from low disk space.

@blackgirlbytes
fix: docs workflow cleanup and prevent cancellations
57d5548 
- Remove unnecessary push trigger from pr-website-preview.yml
  The push trigger was running on every push to every branch but doing
  nothing useful (deploy step was skipped due to missing PR context).
  The pull_request trigger with 'synchronize' already handles PR updates.

- Add cancel-in-progress: false to pr-website-preview.yml
  This prevents cleanup jobs from being cancelled when they run
  concurrently with deploy jobs, which was causing PR previews to
  accumulate and fill up disk space.
@blackgirlbytes blackgirlbytes force-pushed the fix/docs-workflow-cleanup branch from 225cf26 to 57d5548 Compare January 26, 2026 16:42
@blackgirlbytes blackgirlbytes merged commit 130610a into main Jan 26, 2026
28 of 32 checks passed
@blackgirlbytes blackgirlbytes deleted the fix/docs-workflow-cleanup branch January 26, 2026 19:27
This was referenced Jan 27, 2026
Closed
Open
zanesq added a commit that referenced this pull request Jan 27, 2026
@zanesq
Merge remote-tracking branch 'origin/main' into zane/reduced-motion-s…
c444d95 
…upport

* origin/main: (79 commits)
  fix[format/openai]: return error on empty msg. (#6511)
  Fix: ElevenLabs API Key Not Persisting (#6557)
  Logging uplift for model training purposes (command injection model) [Small change] (#6330)
  fix(goose): only send agent-session-id when a session exists (#6657)
  BERT-based command injection detection in tool calls (#6599)
  chore: [CONTRIBUTING.md] add Hermit to instructions (#6518)
  fix: update Gemini context limits (#6536)
  Document r slash command (#6724)
  Upgrade GitHub Actions to latest versions (#6700)
  fix: Manual compaction does not update context window. (#6682)
  Removed the Acceptable Usage Policy (#6204)
  Document spellcheck toggle (#6721)
  fix: docs workflow cleanup and prevent cancellations (#6713)
  Docs: file bug directly (#6718)
  fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679)
  Speed up Databricks provider init by removing fetch of supported models (#6616)
  fix: correct typos in documentation and Justfile (#6686)
  docs: frameDomains and baseUriDomains for mcp apps (#6684)
  docs: add Remotion video creation tutorial (#6675)
  docs: export recipe and copy yaml (#6680)
  ...

# Conflicts:
#	ui/desktop/src/hooks/useChatStream.ts
katzdave added a commit that referenced this pull request Jan 27, 2026
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/canonical-pr…
6cf36f3 
…ovider

* 'main' of github.com:block/goose:
  fix: Manual compaction does not update context window. (#6682)
  Removed the Acceptable Usage Policy (#6204)
  Document spellcheck toggle (#6721)
  fix: docs workflow cleanup and prevent cancellations (#6713)
  Docs: file bug directly (#6718)
  fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679)
  Speed up Databricks provider init by removing fetch of supported models (#6616)
  fix: correct typos in documentation and Justfile (#6686)
  docs: frameDomains and baseUriDomains for mcp apps (#6684)
zanesq added a commit that referenced this pull request Jan 27, 2026
@zanesq
Merge branch 'main' of github.com:block/goose into spence/nav
6dde8c2 
* 'main' of github.com:block/goose:
  Create default gooseignore file when missing (#6498)
  fix slash and @ keyboard navigation popover background color (#6550)
  fix[format/openai]: return error on empty msg. (#6511)
  Fix: ElevenLabs API Key Not Persisting (#6557)
  Logging uplift for model training purposes (command injection model) [Small change] (#6330)
  fix(goose): only send agent-session-id when a session exists (#6657)
  BERT-based command injection detection in tool calls (#6599)
  chore: [CONTRIBUTING.md] add Hermit to instructions (#6518)
  fix: update Gemini context limits (#6536)
  Document r slash command (#6724)
  Upgrade GitHub Actions to latest versions (#6700)
  fix: Manual compaction does not update context window. (#6682)
  Removed the Acceptable Usage Policy (#6204)
  Document spellcheck toggle (#6721)
  fix: docs workflow cleanup and prevent cancellations (#6713)
  Docs: file bug directly (#6718)
This was referenced Jan 29, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dianed-square dianed-square dianed-square approved these changes

@emma-squared emma-squared Awaiting requested review from emma-squared

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blackgirlbytes @dianed-square