Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates recipe error types to improve user-facing error messages by hiding implementation details. It merges RecipeError::TemplateRendering and RecipeError::RecipeParsing into a single RecipeError::Invalid variant, and renames the internal template name from "recipe_template" to "recipe".
Changes:
- Consolidated two error variants (
TemplateRenderingandRecipeParsing) into a singleInvalidvariant for clearer error messages - Renamed internal template name constant from "recipe_template" to "recipe" to improve error message readability
- Updated all test cases to match the new error variant
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/goose/src/recipe/template_recipe.rs | Changed CURRENT_TEMPLATE_NAME from "recipe_template" to "recipe" for better error messages |
| crates/goose/src/recipe/build_recipe/mod.rs | Consolidated TemplateRendering and RecipeParsing error variants into single Invalid variant |
| crates/goose/src/recipe/build_recipe/tests.rs | Updated all test assertions to expect RecipeError::Invalid instead of the old variants |
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When user runs Goose CLI, when there is some error in template, it will show error message
This is not intuitive to user because templating is the implementation details and is not intuitive to some users.
What
InvalidError and provide better messagerecipeAfter change, the error message is
Type of Change
AI Assistance
Testing
Unit test