Removed redundant extension check with goose config when resuming a session #6759
Merged
lifeizhou-ap merged 1 commit intomainfrom Jan 28, 2026
Merged
Conversation
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the CLI’s resume-time “missing extensions” check that compared session-saved extensions against the current global goose config, avoiding redundant/incorrect warnings or cancellations when resuming sessions.
Changes:
- Deleted
check_missing_extensions_or_exitand its dependency onget_extension_by_name. - Simplified the resume-path extension selection to directly use
EnabledExtensionsState’s saved extensions (falling back toget_enabled_extensionswhen absent). - Cleaned up related imports.
wpfleger96
approved these changes
Jan 28, 2026
lifeizhou-ap
deleted the
lifei/remove-check_missing_extensions_or_exit
branch
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
check_missing_extensions_or_exitfunction. The function checks whether original session extension exists goose config when resuming a session. This check is redundant and unnecessary now.Discussion: #6502 (comment)
Type of Change
Testing
Manual