acp: load configured extensions and refactor tests

[codefromthecrypt]

Summary

This allows ACP to read and use the global extensions defined in goose config file. As these are global, they are loaded only once during initialization, not per session, the same way builtins are.

This also opportunistically refactors tests for the upcoming #6305 (providers), so that the diff there is less huge. Notably the tests now check the session_id more strictly and allow exact re-use between client (acp provider) and server (goose acp) modes.

Type of Change

• Bug fix
• Refactor / Code quality

AI Assistance

• This PR was created or reviewed with AI assistance

Testing

New integration test that writes a config file for an MCP server and proves it was loaded as an extension by using it.

[codefromthecrypt]

this is the new test

[Copilot]

Pull request overview

This PR updates ACP so it loads globally configured extensions from the goose config file and refactors ACP server tests into reusable fixtures, improving session ID validation and enabling testing of configured extensions.

Changes:

• Introduced get_extensions_map_with_config / get_enabled_extensions_with_config to read extensions from an arbitrary Config instance, and used this in the ACP server to load configured extensions from config.yaml.
• Refactored ACP server tests into shared fixtures (fixtures and common_tests modules), adding a ClientToAgentSession abstraction, permission handling helpers, and a new run_configured_extension integration test.
• Renamed GooseAcpConfig to AcpServerConfig and extended ACP server initialization to load both builtins and configured extensions while wiring through access to the PermissionManager.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/goose/src/config/extensions.rs	Adds config-parameterized extension loading helpers so non-global configs (like ACP’s config dir) can resolve enabled extensions consistently.
crates/goose-mcp/.gooseignore	Introduces a default .gooseignore template for the goose-mcp crate with sensible secret/env ignores.
crates/goose-acp/.gooseignore	Same .gooseignore template added for the goose-acp crate to protect env and secrets files.
crates/goose-acp/src/server.rs	Renames GooseAcpConfig to AcpServerConfig, exposes permission_manager, and on startup now reads config.yaml in config_dir to load enabled extensions in addition to builtins.
crates/goose-acp/tests/server_test.rs	Simplifies ACP server tests to thin wrappers around shared common_tests helpers using run_test and ClientToAgentSession.
crates/goose-acp/tests/fixtures/mod.rs	Builds reusable test infrastructure (OpenAI mocks, MCP fixtures, permission mapping, ACP in-process server spawning, and a generic Session trait plus run_test harness).
crates/goose-acp/tests/fixtures/server.rs	Implements ClientToAgentSession using SACP, tracking notifications, permissions, and session IDs for reuse across tests.
crates/goose-acp/tests/common_tests/mod.rs	Provides shared test flows (basic completion, MCP HTTP server, builtins+MCP, permission persistence, and configured extension loading) parameterized by session type.
crates/goose-acp/Cargo.toml	Adds async-trait as a dev-dependency for async test trait implementations.
clippy-baselines/too_many_lines.txt	Updates Clippy baseline to acknowledge an additional long function in the security module.
Cargo.lock	Updates lockfile to include async-trait for the goose-acp crate.

Comments suppressed due to low confidence (1)

crates/goose-acp/src/server.rs:57

• Renaming the public GooseAcpConfig struct to AcpServerConfig without a type alias or deprecated wrapper is a breaking API change for any external users of goose_acp::server, so consider either adding a pub type GooseAcpConfig = AcpServerConfig; for backward compatibility or documenting this as an intentional breaking change in the crate's release notes.

pub struct AcpServerConfig {
    pub provider: Arc<dyn goose::providers::base::Provider>,
    pub builtins: Vec<String>,
    pub data_dir: std::path::PathBuf,
    pub config_dir: std::path::PathBuf,
    pub goose_mode: goose::config::GooseMode,
}

[zhixiongdu027]

I've also encountered the issue where the global configuration doesn't take effect in ACP mode. Please help move this forward as soon as possible. Thanks!

[michaelneale]

LGTM - did you mean to add to the too_many_lines.txt

[michaelneale]

merging as has hit me and others.