feat(desktop): add right-click context menu to rename sessions in sidebar#6841
Closed
tfsq wants to merge 1 commit intoblock:mainfrom
Closed
feat(desktop): add right-click context menu to rename sessions in sidebar#6841tfsq wants to merge 1 commit intoblock:mainfrom
tfsq wants to merge 1 commit intoblock:mainfrom
Conversation
…ebar - Add onContextMenu handler to session items in sidebar - Add RenameModal component for editing session names - Wire rename to existing updateSessionName API - Dispatch SESSION_RENAMED event to sync with other components - Show toast notification on success/failure Closes block#6754
Collaborator
|
@tfsq really appreciate it! I think we can reuse our existing code for the rename and save on some of the added code here was some feedback from goose, do you mind taking a look? |
10 tasks
Collaborator
|
closing in favor of #6995 for now, we may consider this later if we decide the inline option isn't working well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds right-click context menu to session items in the sidebar for quick renaming.
Changes
onContextMenuhandler to session items inAppSidebar.tsxRenameModalcomponent for inline editingupdateSessionNameAPISESSION_RENAMEDevent to sync with other componentsMotivation
Current rename flow requires: Sidebar → View All → hover → pencil icon. This is buried. Right-click rename is standard UX in chat apps (Slack, Discord, iMessage).
Closes #6754