Skip to content

feat: pass env to shell command#6863

Merged
jamadeo merged 1 commit intoblock:mainfrom
lsytj0413:pass-envs-to-command
Feb 3, 2026
Merged

feat: pass env to shell command#6863
jamadeo merged 1 commit intoblock:mainfrom
lsytj0413:pass-envs-to-command

Conversation

@lsytj0413
Copy link
Contributor

Summary

Type of Change

  • Bug fix

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Related Issues

Relates to #ISSUE_ID
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

Signed-off-by: lsytj0413 <511121939@qq.com>
@alexhancock
Copy link
Collaborator

@jamadeo Remind me, did we used to do this and we removed it? Trying to remember if there is some reason why we don't want to

Copy link
Collaborator

@jamadeo jamadeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexhancock I do think this is (was) a bug - I'm not sure why we wouldn't pass this. It's related, but separate from the back-and-forth we did with setting PATH using an interactive shell. Thanks for the fix @lsytj0413

@jamadeo jamadeo added this pull request to the merge queue Feb 3, 2026
Merged via the queue into block:main with commit 3e38c30 Feb 3, 2026
18 checks passed
@lsytj0413 lsytj0413 deleted the pass-envs-to-command branch February 4, 2026 01:18
stebbins pushed a commit to stebbins/goose that referenced this pull request Feb 4, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
Signed-off-by: Harrison <hcstebbins@gmail.com>
kuccello pushed a commit to kuccello/goose that referenced this pull request Feb 7, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Signed-off-by: lsytj0413 <511121939@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants