Merged
Conversation
michaelneale
approved these changes
Feb 3, 2026
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
nice - seems thorough. @zanesq how did you make the list of safe ones?
Collaborator
Author
|
I just asked goose for the most common deeplinks, obviously cant get them all but its a good start I think. Can always add more later if needed and if not recognized it will prompt the user to open it. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
stebbins
pushed a commit
to stebbins/goose
that referenced
this pull request
Feb 4, 2026
Signed-off-by: Harrison <hcstebbins@gmail.com>
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking a deeplink in markdown was opening a blank window and not working
ReactMarkdown's default
urlTransformonly allowshttp,https,mailto,irc,ircs, andxmppprotocols.All other protocols (like
spotify:,vscode:,slack:) were being stripped to empty strings.Also added security checks now that we are overwriting the default rendering for the links. Known safe protocols are rendered and allowed. Unknown protocols pop a warning confirmation first. Risky ones are not rendered and blocked.
Verified working now with deeplinks in markdown and regular links as before.