Fast models on databricks have 0 retries.#6919
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that Databricks “fast” models (and embeddings) use a zero‑retry policy so they fail quickly instead of being retried with the standard backoff configuration.
Changes:
- Extends the
ProviderRetrytrait with a configurablewith_retry_confighelper and reimplementswith_retryin terms of it. - Adds a separate
fast_retry_configtoDatabricksProvider, hardcoded to 0 retries, wired through both environment- and parameter-based constructors. - Updates Databricks completion and embedding calls to use
fast_retry_configwhen invoking the fast model (and always for embeddings), while preserving existing retry behavior for non-fast models and streaming.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/goose/src/providers/retry.rs | Adds a configurable with_retry_config method to the ProviderRetry trait and makes with_retry delegate to it, enabling per-call retry configuration. |
| crates/goose/src/providers/databricks.rs | Introduces a dedicated 0-retry fast_retry_config for Databricks, wires it into provider construction, and applies it to fast-model completions and embeddings while leaving standard retry behavior unchanged elsewhere. |
DOsinga
approved these changes
Feb 5, 2026
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.