Skip to content

Fast models on databricks have 0 retries.#6919

Merged
katzdave merged 3 commits intomainfrom
dkatz/speed-fast
Feb 5, 2026
Merged

Fast models on databricks have 0 retries.#6919
katzdave merged 3 commits intomainfrom
dkatz/speed-fast

Conversation

@katzdave
Copy link
Collaborator

@katzdave katzdave commented Feb 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 3, 2026 17:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures that Databricks “fast” models (and embeddings) use a zero‑retry policy so they fail quickly instead of being retried with the standard backoff configuration.

Changes:

  • Extends the ProviderRetry trait with a configurable with_retry_config helper and reimplements with_retry in terms of it.
  • Adds a separate fast_retry_config to DatabricksProvider, hardcoded to 0 retries, wired through both environment- and parameter-based constructors.
  • Updates Databricks completion and embedding calls to use fast_retry_config when invoking the fast model (and always for embeddings), while preserving existing retry behavior for non-fast models and streaming.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/goose/src/providers/retry.rs Adds a configurable with_retry_config method to the ProviderRetry trait and makes with_retry delegate to it, enabling per-call retry configuration.
crates/goose/src/providers/databricks.rs Introduces a dedicated 0-retry fast_retry_config for Databricks, wires it into provider construction, and applies it to fast-model completions and embeddings while leaving standard retry behavior unchanged elsewhere.

@katzdave katzdave added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit c02135c Feb 5, 2026
24 checks passed
@katzdave katzdave deleted the dkatz/speed-fast branch February 5, 2026 15:55
kuccello pushed a commit to kuccello/goose that referenced this pull request Feb 7, 2026
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants