Conversation
|
/goose |
There was a problem hiding this comment.
Pull request overview
This PR switches the Databricks fast model from "gemini-2-5-flash" to "databricks-claude-haiku-4-5" to address slow compaction performance. The change aligns with using Anthropic models that are used for main operations.
Changes:
- Updated default fast model constant to use Claude Haiku 4.5 instead of Gemini 2.5 Flash
- Added environment variable override capability to the compaction test script for easier testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/goose/src/providers/databricks.rs | Changed DATABRICKS_DEFAULT_FAST_MODEL from "gemini-2-5-flash" to "databricks-claude-haiku-4-5" |
| scripts/test_compaction.sh | Added COMPACTION_PROVIDER and COMPACTION_MODEL environment variables to override provider/model settings during testing |
| pub const DATABRICKS_DEFAULT_MODEL: &str = "databricks-claude-sonnet-4"; | ||
| const DATABRICKS_DEFAULT_FAST_MODEL: &str = "gemini-2-5-flash"; | ||
| const DATABRICKS_DEFAULT_FAST_MODEL: &str = "databricks-claude-haiku-4-5"; | ||
| pub const DATABRICKS_KNOWN_MODELS: &[&str] = &[ |
There was a problem hiding this comment.
The new fast model "databricks-claude-haiku-4-5" should be added to DATABRICKS_KNOWN_MODELS. This list is used for provider metadata to help users discover available models, and the default fast model should be included.
| pub const DATABRICKS_KNOWN_MODELS: &[&str] = &[ | |
| pub const DATABRICKS_KNOWN_MODELS: &[&str] = &[ | |
| "databricks-claude-haiku-4-5", |
PR #6943 Review: Use haiku for databricksSummary: This PR changes the Databricks provider's default fast model from AnalysisThe fast model is used internally for compaction and session naming via
✅ Highlights
🟢 Suggestions
const DATABRICKS_KNOWN_MODELS: &[&str] = &[
"databricks-claude-sonnet-4",
"databricks-claude-haiku-4-5", // Add this
"databricks-meta-llama-3-3-70b-instruct",
// ...
];This PR looks good to merge. Review generated by goose |
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Harrison <hcstebbins@gmail.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Summary
We're seeing compaction being super slow internally. Switching to anthropic models that we use for the main model mostly would be a solution