Skip to content

Fix gemini cli command parsing#6960

Merged
katzdave merged 1 commit intomainfrom
dkatz/fix-cli-command
Feb 5, 2026
Merged

Fix gemini cli command parsing#6960
katzdave merged 1 commit intomainfrom
dkatz/fix-cli-command

Conversation

@katzdave
Copy link
Collaborator

@katzdave katzdave commented Feb 4, 2026

Summary

OS string causing problems and not actually looking at the environment variable.

Copilot AI review requested due to automatic review settings February 4, 2026 20:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes command parsing for CLI-based providers by changing the configuration value type from OsString to String.

Changes:

  • Updated config macro to use String instead of OsString for command configuration values (GEMINI_CLI_COMMAND, CURSOR_AGENT_COMMAND, CODEX_COMMAND, CLAUDE_CODE_COMMAND)
  • Modified all four CLI providers to use String type and pass commands by reference to SearchPaths::resolve()
  • Removed unnecessary OsString imports from all affected files

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/goose/src/config/base.rs Changed config_value! macro declarations from OsString to String for all four command configs
crates/goose/src/providers/gemini_cli.rs Updated to use String type and pass command by reference, removed OsString import
crates/goose/src/providers/cursor_agent.rs Updated to use String type and pass command by reference, removed OsString import
crates/goose/src/providers/codex.rs Updated to use String type and pass command by reference, removed OsString import
crates/goose/src/providers/claude_code.rs Updated to use String type and pass command by reference, removed OsString import

@katzdave katzdave added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 66a2a3c Feb 5, 2026
22 of 23 checks passed
@katzdave katzdave deleted the dkatz/fix-cli-command branch February 5, 2026 16:06
katzdave added a commit that referenced this pull request Feb 6, 2026
kuccello pushed a commit to kuccello/goose that referenced this pull request Feb 7, 2026
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants