Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes command parsing for CLI-based providers by changing the configuration value type from OsString to String.
Changes:
- Updated config macro to use
Stringinstead ofOsStringfor command configuration values (GEMINI_CLI_COMMAND, CURSOR_AGENT_COMMAND, CODEX_COMMAND, CLAUDE_CODE_COMMAND) - Modified all four CLI providers to use
Stringtype and pass commands by reference toSearchPaths::resolve() - Removed unnecessary
OsStringimports from all affected files
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/goose/src/config/base.rs | Changed config_value! macro declarations from OsString to String for all four command configs |
| crates/goose/src/providers/gemini_cli.rs | Updated to use String type and pass command by reference, removed OsString import |
| crates/goose/src/providers/cursor_agent.rs | Updated to use String type and pass command by reference, removed OsString import |
| crates/goose/src/providers/codex.rs | Updated to use String type and pass command by reference, removed OsString import |
| crates/goose/src/providers/claude_code.rs | Updated to use String type and pass command by reference, removed OsString import |
DOsinga
approved these changes
Feb 5, 2026
katzdave
added a commit
that referenced
this pull request
Feb 6, 2026
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OS string causing problems and not actually looking at the environment variable.