Conversation
|
Please, feel free to close mine if this is better suited. |
There was a problem hiding this comment.
Pull request overview
This PR removes two unused reqwest features (json and rustls-tls-native-roots) from the build-dependencies section while preserving the system-proxy feature. This is a follow-up to PR #6946, which attempted to remove the entire build-dependencies section but was updated to keep system-proxy after another maintainer added it.
Changes:
- Removed
jsonandrustls-tls-native-rootsfeatures from reqwest in build-dependencies
| [build-dependencies] | ||
| tokio = { workspace = true } | ||
| reqwest = { workspace = true, features = [ | ||
| "json", | ||
| "rustls-tls-native-roots", | ||
| "system-proxy", | ||
| ], default-features = false } |
There was a problem hiding this comment.
The entire [build-dependencies] section can be removed, not just specific features. There's no build.rs file in crates/goose/, so these dependencies (including system-proxy) are completely unused. The system-proxy feature is already present where it's actually needed - in the [dependencies] section on line 36.
|
Looking at it closer, it looks like we can just remove it. Can you rebase yours @r0x0d ? |
sure! let me rebase. |
2 participants
An updated version of #6946 that removes the
jsonandrustls-tls-native-rootsentries without removing the wholebuild-dependenciessectionReason: a newer change from @DOsinga added
system-proxy. Douwe, unless you confirm that also isn't needed this seems like the best resolution for #6946 for now