More no-window flags by jamadeo · Pull Request #7122 · block/goose

jamadeo · 2026-02-10T16:31:38Z

We were missing these on a few subprocess creations

Copilot

Pull request overview

This PR reduces unwanted console window pop-ups on Windows by setting CREATE_NO_WINDOW on various subprocess invocations across the core goose crate, CLI, and MCP server components.

Changes:

Add Windows-only creation_flags(CREATE_NO_WINDOW) to multiple Command invocations (tokio + std).
Refactor several command constructions to let mut cmd = ...; cmd.args(...); ...; cmd.output()/status() to enable setting flags before execution.
Add Windows CommandExt imports where needed for std::process::Command.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/goose/src/providers/azureauth.rs	Prevents Azure CLI token fetch from spawning a visible window on Windows.
crates/goose/src/posthog.rs	Prevents `cmd /C ver` telemetry platform detection from opening a window on Windows.
crates/goose/src/agents/retry.rs	Prevents retry success-check shell commands from opening a window on Windows.
crates/goose-mcp/src/developer/shell.rs	Prevents developer shell commands and `taskkill` from opening windows on Windows.
crates/goose-mcp/src/developer/paths.rs	Prevents PATH discovery shell calls from opening a window on Windows.
crates/goose-mcp/src/computercontroller/platform/windows.rs	Prevents PowerShell automation script execution from opening a window on Windows.
crates/goose-mcp/src/computercontroller/mod.rs	Prevents automation script execution paths from opening a window on Windows.
crates/goose-cli/src/session/output.rs	Prevents status hook execution via `cmd /C ...` from opening a window on Windows.
crates/goose-cli/src/recipes/github_recipe.rs	Prevents `gh`/`git` helper commands used for GitHub recipes from opening windows on Windows.

Copilot · 2026-02-10T16:35:44Z

crates/goose/src/providers/azureauth.rs

+        #[cfg(windows)]
+        cmd.creation_flags(0x08000000 /* CREATE_NO_WINDOW */);
+        let output = cmd


The Windows CREATE_NO_WINDOW flag is currently an inline magic number; consider reusing a shared helper (e.g., crate::subprocess::configure_subprocess) or a local const to avoid duplicating 0x08000000 and keep subprocess configuration consistent.

Copilot · 2026-02-10T16:35:45Z

crates/goose-cli/src/recipes/github_recipe.rs

+    let mut cmd = Command::new("gh");
+    cmd.args(["auth", "status"]);
+    #[cfg(windows)]
+    cmd.creation_flags(0x08000000 /* CREATE_NO_WINDOW */);
+    let status = cmd.status().map_err(|_| {
+        anyhow::anyhow!("Failed to run `gh auth status`. Make sure you have `gh` installed.")
+    })?;


This repeats the Windows CREATE_NO_WINDOW value in several places in this module; consider introducing a module-level const for 0x08000000 (or a small helper) to reduce duplication and make the intent clearer.

+1 does using a const make sense?

@katzdave yeah, it does, but it means you have to either make that also conditionally compile, and/or tell the linter it can be unused (in non-windows mode), with similar flags everywhere you import it if it's in a use

replaced it with an extension trait which makes this all much cleaner

katzdave · 2026-02-10T17:19:49Z

crates/goose-cli/src/recipes/github_recipe.rs

+    let mut cmd = Command::new("gh");
+    cmd.args(["auth", "status"]);
+    #[cfg(windows)]
+    cmd.creation_flags(0x08000000 /* CREATE_NO_WINDOW */);
+    let status = cmd.status().map_err(|_| {
+        anyhow::anyhow!("Failed to run `gh auth status`. Make sure you have `gh` installed.")
+    })?;


+1 does using a const make sense?

…e-no-window-flag

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

* upstream/main: (109 commits) [docs] Skills Marketplace UI Improvements (block#7158) More no-window flags (block#7122) feat: Allow overriding default bat themes using environment variables (block#7140) Make the system prompt smaller (block#6991) Pre release script (block#7145) Spelling (block#7137) feat(mcp): upgrade rmcp to 0.15.0 and advertise MCP Apps UI extension capability (block#6927) fix: ensure assistant messages with tool_calls include content field (block#7076) fix(canonical): handle gcp_vertex_ai model mapping correctly (block#6836) Group dependencies in root Cargo.toml (block#6948) refactor: updated elevenLabs API module and `remove button` UX (block#6781) fix: we were missing content from langfuse traces (block#7135) docs: update username in authors.yml (block#7132) fix extension selector syncing issues (block#7133) fix(acp): per-session Agent for model isolation and load_session restore (block#7115) fix(claude-code): defensive coding improvements for model switching (block#7131) feat(claude-code): dynamic model listing and mid-session model switching (block#7120) Inline worklet source (block#7128) [docs] One shot prompting is dead - Blog Post (block#7113) fix: correct spelling of Debbie O'Brien's name in authors.yml (block#7127) ...

* origin/main: (33 commits) fix: replace panic with proper error handling in get_tokenizer (#7175) Lifei/smoke test for developer (#7174) fix text editor view broken (#7167) docs: White label guide (#6857) Add PATH detection back to developer extension (#7161) docs: pin version in ci/cd (#7168) Desktop: - No Custom Headers field for custom OpenAI-compatible providers (#6681) feat: edit model and extensions of a recipe from GUI (#6804) feat: MCP support for agentic CLI providers (#6972) docs: keyring fallback to secrets.yaml (#7165) feat: load provider/model specified inside the recipe config (#6884) fix ask-ai bot hitting tool call limits (#7162) fix flatpak icon (#7154) [docs] Skills Marketplace UI Improvements (#7158) More no-window flags (#7122) feat: Allow overriding default bat themes using environment variables (#7140) Make the system prompt smaller (#6991) Pre release script (#7145) Spelling (#7137) feat(mcp): upgrade rmcp to 0.15.0 and advertise MCP Apps UI extension capability (#6927) ...

More no-window flags

aed458d

Copilot AI review requested due to automatic review settings February 10, 2026 16:31

Copilot started reviewing on behalf of jamadeo February 10, 2026 16:32 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

katzdave approved these changes Feb 10, 2026

View reviewed changes

jamadeo added 5 commits February 11, 2026 09:47

Merge remote-tracking branch 'origin/main' into jackamadeo/more-creat…

c84e413

…e-no-window-flag

Extension trait

79aac47

more chaining

0cdc1e3

Missed new file

7f98a9b

flags

fe5bf0e

Copilot AI review requested due to automatic review settings February 11, 2026 16:22

Copilot started reviewing on behalf of jamadeo February 11, 2026 16:23 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

jamadeo added this pull request to the merge queue Feb 11, 2026

Merged via the queue into main with commit fb47728 Feb 11, 2026
25 checks passed

jamadeo deleted the jackamadeo/more-create-no-window-flag branch February 11, 2026 17:53

This was referenced Feb 12, 2026

chore(release): release version 1.24.0 (minor) #7102

Closed

chore(release): release version 1.25.0 (minor) #7263

Open

jamadeo mentioned this pull request Feb 17, 2026

fix(windows): prevent console window flickering when spawning subproc… #6827

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More no-window flags#7122

More no-window flags#7122
jamadeo merged 6 commits intomainfrom
jackamadeo/more-create-no-window-flag

jamadeo commented Feb 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

katzdave Feb 10, 2026

Uh oh!

jamadeo Feb 10, 2026

Uh oh!

jamadeo Feb 11, 2026

Uh oh!

katzdave Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jamadeo commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

katzdave Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

katzdave Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jamadeo commented Feb 10, 2026 •

edited

Loading