refactor: extract shared CLI provider helpers into cli_common.rs#7200
Closed
rabi wants to merge 1 commit intoblock:mainfrom
Closed
refactor: extract shared CLI provider helpers into cli_common.rs#7200rabi wants to merge 1 commit intoblock:mainfrom
rabi wants to merge 1 commit intoblock:mainfrom
Conversation
Deduplicate is_session_description_request and generate_simple_session_description across the four CLI providers (claude_code, codex, cursor_agent, gemini_cli) into a shared cli_common module. Also fixes a bug where these providers reported self.model.model_name in ProviderUsage instead of the model_config.model_name passed by complete_fast, causing session titles to be attributed to the wrong model. Change-Id: Iae301d44f77cf8d5db27f66e4a3d78cd0c28bc02 Signed-off-by: rabi <ramishra@redhat.com>
Contributor
Author
|
I'll add this change to #6833 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicate is_session_description_request and
generate_simple_session_description across the four CLI providers (claude_code, codex, cursor_agent, gemini_cli) into a shared cli_common module.
Also fixes a bug where these providers reported self.model.model_name in ProviderUsage instead of the model_config.model_name passed by complete_fast, causing session titles to be attributed to the wrong model.
Type of Change