install node in goose dir (#7220)#7267
Merged
lifeizhou-ap merged 1 commit intorelease/1.25.0from Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the system-wide Node.js installation approach with a portable, version-pinned Node.js installation that downloads to the user's local Goose directory. The change eliminates the need for admin privileges and provides better version control.
Changes:
- Removed separate
install-node.cmdscript in favor of integrated portable Node.js installation innpx.cmd - Modified
npx.cmdto download and extract Node.js v22.14.0 to%LOCALAPPDATA%\Goose\nodeon-demand - Updated
winShims.tsto no longer copy the now-deletedinstall-node.cmdfile - Added
workflow_dispatchtrigger to Windows bundle workflow for manual testing
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/desktop/src/utils/winShims.ts | Removed install-node.cmd from the list of Windows shims to copy |
| ui/desktop/src/platform/windows/bin/npx.cmd | Replaced system Node.js lookup with portable Node.js download and installation logic |
| ui/desktop/src/platform/windows/bin/install-node.cmd | Deleted file - functionality moved into npx.cmd |
| .github/workflows/bundle-desktop-windows.yml | Added workflow_dispatch trigger for manual workflow execution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.