Skip to content

Improve link confirmation modal#7333

Merged
zanesq merged 1 commit intomainfrom
zane/link-confirmation-modal
Feb 19, 2026
Merged

Improve link confirmation modal#7333
zanesq merged 1 commit intomainfrom
zane/link-confirmation-modal

Conversation

@zanesq
Copy link
Collaborator

@zanesq zanesq commented Feb 18, 2026

Summary

Fixed the confirm-open-link modal not scrolling when URLs are very long,
making the action buttons unreachable.

Replaced the native Electron showMessageBox dialog with the existing React
ConfirmationModal component for the external link confirmation flow. The
ConfirmationModal now supports an optional scrollable detail section with
max viewport height constraints, so long URLs wrap and scroll while the
Cancel/Open buttons always remain visible and accessible.

Also added error handling for when no application is found to open the
link protocol, and improved keyboard focus visibility on the modal buttons
using the theme accent color instead of the barely-visible default ring.

Screenshot 2026-02-18 at 2 57 53 PM Screenshot 2026-02-18 at 2 57 42 PM

Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zanesq zanesq added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit 3d0ece7 Feb 19, 2026
19 checks passed
@zanesq zanesq deleted the zane/link-confirmation-modal branch February 19, 2026 15:19
katzdave added a commit that referenced this pull request Feb 19, 2026
* 'main' of github.com:block/goose: (24 commits)
  Docs: claude code uses stream-json (#7358)
  Improve link confirmation modal (#7333)
  fix(ci): deflake smoke tests for Google models (#7344)
  feat: add Cerebras provider support (#7339)
  fix: skip whitespace-only text blocks in Anthropic message (#7343)
  fix(goose-acp): heap allocations (#7322)
  Remove trailing space from links (#7156)
  fix: detect low balance and prompt for top up (#7166)
  feat(apps): add support for MCP apps to sample (#7039)
  Typescript SDK for ACP extension methods (#7319)
  chore: upgrade to rmcp 0.16.0 (#7274)
  docs: add monitoring subagent activity section (#7323)
  docs: document Desktop UI recipe editing for model/provider and extensions (#7327)
  docs: add CLAUDE_THINKING_BUDGET and CLAUDE_THINKING_ENABLED environm… (#7330)
  fix: display 'Code Mode' instead of 'code_execution' in CLI (#7321)
  docs: add Permission Policy documentation for MCP Apps (#7325)
  update RPI plan prompt (#7326)
  docs: add CLI syntax highlighting theme customization (#7324)
  fix(cli): replace shell-based update with native Rust implementation (#7148)
  docs: rename Code Execution extension to Code Mode extension (#7316)
  ...
michaelneale added a commit that referenced this pull request Feb 19, 2026
* main: (46 commits)
  chore(deps): bump hono from 4.11.9 to 4.12.0 in /ui/desktop (#7369)
  Include 3rd-party license copy for JavaScript/CSS minified files (#7352)
  docs for reasoning env var (#7367)
  docs: update skills detail page to reference Goose Summon extension (#7350)
  fix(apps): restore MCP app sampling support reverted by #6933 (#7366)
  feat: TUI client of goose-acp (#7362)
  docs: agent variable (#7365)
  docs: pass env vars to shell (#7361)
  docs: update sandbox topic (#7336)
  feat: add local inference provider with llama.cpp backend and HuggingFace model management (#6933)
  Docs: claude code uses stream-json (#7358)
  Improve link confirmation modal (#7333)
  fix(ci): deflake smoke tests for Google models (#7344)
  feat: add Cerebras provider support (#7339)
  fix: skip whitespace-only text blocks in Anthropic message (#7343)
  fix(goose-acp): heap allocations (#7322)
  Remove trailing space from links (#7156)
  fix: detect low balance and prompt for top up (#7166)
  feat(apps): add support for MCP apps to sample (#7039)
  Typescript SDK for ACP extension methods (#7319)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments