feat: substitute version in CLI and Desktop App during release #925
+55
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman1993
changed the title
|
nice |
alexhancock
approved these changes
Jan 30, 2025
| prerelease: true # TODO: remove after testing |
There was a problem hiding this comment.
Does this need a sweep through to remove or uncomment things noted with TODOs? Noticed a few
There was a problem hiding this comment.
yeah still need to cleanup. let me merge to lily's branch and then i'll do another sweep. did you get a chance to test this out the app - https://github.com/block/goose/releases/tag/untagged-fe0426d4b3b96b1ddc30?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow succeeded: https://github.com/block/goose/actions/runs/13045348906
test release (draft) - tagged it as
test.1.0.1: https://github.com/block/goose/releases/tag/untagged-fe0426d4b3b96b1ddc30downloaded the CLI and App. looks like the version injections worked:
