fix deployment

block · Oct 10, 2024 · 3214aba · 3214aba
1 parent ede05f9
commit 3214aba
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 41 deletions.
diff --git a/.github/workflows/projects-dashboard.yml b/.github/workflows/projects-dashboard.yml
@@ -1,4 +1,4 @@
-name: Build projects-dashboard and maybe Deploy to GitHub Pages
+name: Build and deploy projects-dashboard
 
 on:
   push:
@@ -50,7 +50,7 @@ jobs:
           TARGET_PATH=projects-dashboard
           if [ "$BRANCH" != "main" ]; then
             # sanitize branch name
-            BRANCH=$(echo "$BRANCH" | sed 's/[^a-zA-Z0-9]/_/g')
+            BRANCH=$(echo "$BRANCH" | sed 's/[^a-zA-Z0-9-]/_/g')
             TARGET_PATH=projects-dashboard-preview-$BRANCH
           fi
           echo "path=$TARGET_PATH" >> $GITHUB_OUTPUT
@@ -104,7 +104,11 @@ jobs:
       - name: Add preview comment to PR
         if: github.event_name == 'pull_request'
         uses: thollander/actions-comment-pull-request@v2
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
+          comment_tag: preview-deploy
           message: |
             Site preview deployed to: https://block-open-source.github.io/ospo/${{ needs.build.outputs.path }}
-          comment_tag: preview-deploy
+
+            _(execution **[#${{ github.run_id }}](https://github.com/block-open-source/ospo/actions/runs/${{ github.run_id }}) / attempt **${{ github.run_attempt }}**)_
diff --git a/projects-dashboard/src/components/Header.astro b/projects-dashboard/src/components/Header.astro
@@ -10,7 +10,6 @@ const baseURL = import.meta.env.BASE_URL;
     <h2><a href={baseURL}>{SITE_TITLE}</a></h2>
     <div class="internal-links">
       <HeaderLink href={baseURL}>Projects</HeaderLink>
-      <HeaderLink href={`${baseURL}/about`}>About</HeaderLink>
     </div>
   </nav>
 </header>
@@ -54,4 +53,7 @@ const baseURL = import.meta.env.BASE_URL;
       display: none;
     }
   }
+  .internal-links {
+    min-height: 56px;
+  }
 </style>
diff --git a/projects-dashboard/src/pages/about.astro b/projects-dashboard/src/pages/about.astro