Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test drama #161

Closed
wants to merge 1 commit into from
Closed

Test drama #161

wants to merge 1 commit into from

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Apr 3, 2024

Two commits so far.

Get publish consistent with itself

We were installing the old plugin but using the new (.base) API.

Without this config failed:

Caused by: java.lang.IllegalStateException: The value for this property is final and cannot be changed any further.
        at org.gradle.api.internal.provider.AbstractProperty$FinalizedValue.beforeMutate(AbstractProperty.java:498)
        at org.gradle.api.internal.provider.AbstractProperty.assertCanMutate(AbstractProperty.java:272)
        at org.gradle.api.internal.provider.AbstractProperty.setSupplier(AbstractProperty.java:221)
        at org.gradle.api.internal.provider.DefaultProperty.set(DefaultProperty.java:71)
        at com.vanniktech.maven.publish.MavenPublishBaseExtension.publishToMavenCentral(MavenPublishBaseExtension.kt:55)
        at com.vanniktech.maven.publish.MavenPublishPlugin.apply(MavenPublishPlugin.kt:21)

Add logging to figure out why dialog is not getting focus.

Our SDK 30 tests are failing a lot in RadiographyUiTest.waitForFocus, so I've added some logging to give us a little more insight.

@rjrjr rjrjr requested review from pyricau, jamesmosley55 and a team as code owners April 3, 2024 21:00
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2024

CLA assistant check
All committers have signed the CLA.

@rjrjr rjrjr marked this pull request as draft April 3, 2024 21:12
@rjrjr rjrjr changed the title Ray/whatup Test drama Apr 3, 2024
@rjrjr
Copy link
Contributor Author

rjrjr commented Apr 3, 2024

Definitely a flake. The first time I pushed this branch up tests passed.

Our SDK 30 tests are failing a lot in RadiographyUiTest.waitForFocus, so I've added some logging to give us a little more insight.

Neither window is getting focus:

radiography.test.RadiographyUiTest > when_showDialog_then_hierarchyHasTwoWindows[test(AVD) - 11] FAILED 
	Dialog android.app.AlertDialog@1e9b796 is focused: activity not focused
	dialog not focused

radiography.test.RadiographyUiTest > when_onlyFocusedWindow_then_hierarchyHasOnlyDialog[test(AVD) - 11] FAILED 
	Dialog android.app.AlertDialog@1e9b796 is focused: activity not focused
	dialog not focused

I'm going to try deleting a couple of the older api levels in theory there might be some kind of contention / throttling going on, we're going crazy far back IMHO.
Wish I could see a screen grab.

@rjrjr
Copy link
Contributor Author

rjrjr commented Apr 3, 2024

One green run w/just two shards. Going to add one more back in and hit rebuild a few times.

@rjrjr
Copy link
Contributor Author

rjrjr commented Apr 3, 2024

One green run w/just two shards. Going to add one more back in and hit rebuild a few times.

Actually, I don't see why we need more than just 26 and 30, will stick with that and bounce on rebuild.

@rjrjr
Copy link
Contributor Author

rjrjr commented Apr 3, 2024

Different failure this time. These tests are just flakey, and I'm inclined to blame the free tier.

Updates our GHA config to take advantage of the runner that was created to unflake Workflow's integration tests, for the same reason.
@rjrjr rjrjr closed this Apr 22, 2024
@rjrjr rjrjr deleted the ray/whatup branch April 22, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants