Use workflow-kotlin-test-runner-ubuntu-4core to unflake #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rjrjr
force-pushed
the
ray/fatter-runner
branch
from
b482c16 to
0b351b2
Compare
Comment on lines
-3
to
+5
| on: | ||
| push: | ||
| branches: [ main ] | ||
| # Build on all pull requests, regardless of target. | ||
| pull_request: | ||
| on : | ||
| pull_request : | ||
| merge_group : |
There was a problem hiding this comment.
Does this need to be changed as part of this?
There was a problem hiding this comment.
It depends on how securely we want to lock down the custom runner. if we specify the workflows it can run on rather than just open it to any workflow then we need a stable workflow name - which can only happen if we run it on the main branch rather than the new branch that is created for each PR.
|
We need to add the KVM group perms to enable HW acceleration for teh emulator in the action. |
Updates our GHA config to take advantage of the runner that was created to unflake Workflow's integration tests, for the same reason.
rjrjr
force-pushed
the
ray/fatter-runner
branch
from
0b351b2 to
422d76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our GHA config to take advantage of the runner that was created to unflake Workflow's integration tests, for the same reason.