Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider #14

Merged
merged 16 commits into from
Jun 7, 2019
Merged

Slider #14

merged 16 commits into from
Jun 7, 2019

Conversation

m4gpi
Copy link
Member

@m4gpi m4gpi commented Jun 5, 2019

PR for #6

@m4gpi
Copy link
Member Author

m4gpi commented Jun 5, 2019

I've added a few major UI changes in this PR which I've worked in to help streamline the new crystal form. As a result its missing some of the functionality the stand alone currently has. I've PR'ed this into a development branch, so we can rework features into the new UI gradually.

@m4gpi m4gpi changed the base branch from master to development June 5, 2019 18:38
@m4gpi m4gpi mentioned this pull request Jun 5, 2019
3 tasks
@m4gpi
Copy link
Member Author

m4gpi commented Jun 6, 2019

There's issues here with rendering 'trust'. This isn't a simple task and I believe requires discussion amongst the team about how to determine what the 'bands' for trust are. We also need to decide what kind of scale on which we render these 'bands', i.e. how to do the calculation. @dan-mi-sun @ameba23 I'd like it if we could workshop this at some point soon, but for the time being in order to get this ticket shipped, this is pretty much complete, I've implemented a progress bar which we can use to render these bands once we've decided what those exact specifications are.

@m4gpi m4gpi requested a review from ameba23 June 7, 2019 09:11
@m4gpi m4gpi merged commit f17b0d9 into development Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant