Skip to content

Commit

Permalink
feat(VCv2): selector can read name and description properties from bl…
Browse files Browse the repository at this point in the history
…ockcerts v3
  • Loading branch information
lemoustachiste committed Oct 24, 2024
1 parent c407fe9 commit f59913a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
10 changes: 7 additions & 3 deletions src/selectors/certificate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { isValidUrl } from '../helpers/validations';
import { VERIFICATION_STATUSES } from '../constants/verificationStatuses';
import { CONTENT_TYPES } from '../constants/contentTypes';
import getText from '../i18n/getText';
import type { IVerificationMapItem, Signers, Certificate } from '@blockcerts/cert-verifier-js';
import type { IVerificationMapItem, Signers, Certificate, BlockcertsV3 } from '@blockcerts/cert-verifier-js';
import type { BlockcertsVerifierState, IFinalStep } from '../store/getInitialState';
import type { V1Signature } from '../models/V1Signature';

Expand Down Expand Up @@ -57,7 +57,9 @@ export function getCertificateTitle (state: BlockcertsVerifierState): string {
const certificateDefinition = getCertificateDefinition(state);

if (certificateDefinition) {
return certificateDefinition.name;
return certificateDefinition.name ??
(certificateDefinition.certificateJson as BlockcertsV3)?.name ??
'';
}

return '';
Expand Down Expand Up @@ -370,7 +372,9 @@ export function getCertificateDescription (state: BlockcertsVerifierState): stri
const certificateDefinition = getCertificateDefinition(state);

if (certificateDefinition) {
return certificateDefinition.description;
return certificateDefinition.description ??
(certificateDefinition.certificateJson as BlockcertsV3)?.description ??
'';
}

return '';
Expand Down
7 changes: 1 addition & 6 deletions test/application/selectors/certificate.v3.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,13 @@ import {
getCertificateDescription,
getCertificateTitle,
getChain, getDisplayContent, getDisplayContentEncoding, getDisplayContentType,
getDownloadLink,
getIssueDate,
getIssuedOn,
getIssuerLogo,
getIssuerName, getIssuerPublicKey,
getParentStep,
getRecipientName,
getRecordLink, getSigners,
getStartedVerificationSteps,
getTransactionId,
getTransactionLink,
getVerifiedSteps, isTestChain
getTransactionLink
} from '../../../src/selectors/certificate';
import v3_2FixtureMocknet from '../../fixtures/v3/mocknet-vc-v2-name-description.json';
import testnetV3Fixture from '../../fixtures/v3/testnet-v3.0-beta.json';
Expand Down

0 comments on commit f59913a

Please sign in to comment.