Add EIP-1559 fields (cli, airflow, dataflow) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is similar to the EIP-1559 pull request for ethereum-etl: blockchain-etl/ethereum-etl#256 Fields added: - base_fee_per_gas (block) - base fee per gas in protocol, which can move up or down each block according to a formula which is a function of gas used in parent block and gas target (block gas limit divided by elasticity multiplier) of parent block. - max_fee_per_gas (tx) - total fee which covers both the priority fee and the block's network fee per gas - max_priority_fee_per_gas (tx) - maximum fee per gas tx senders are willing to give to miners to incentivize them to include their transaction - transaction_type (tx) - an envelope for future transaction types - effective_gas_price (receipt) - a replacement for gasUsed field
This was referenced Nov 16, 2022
charlielewisme
changed the title
charlielewisme
changed the title
charlielewisme
force-pushed
the
EIP-1559_etl
branch
from
2eb1bfa
to
0bd8b24
Compare
charlielewisme
force-pushed
the
EIP-1559_etl
branch
2 times, most recently
from
67a5aaf
to
f29b616
Compare
Based on nansen-ai/evmchain-etl/pull/55 Add ds postfix for load and enrich tasks Add expiration for temp raw tables Remove unused enrichment sql Support load_all_partitions for export files missing EIP-1559 fields
charlielewisme
force-pushed
the
EIP-1559_etl
branch
from
f29b616
to
b1a8379
Compare
TimNooren
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add EIP-1559 fields to CLI, Airflow and Dataflow
Following up on and consolidating @cffls PRs #64 #65 #66
Why?
EIP-1559
How?
effective_gas_price -> receipt_effective_gas_price(similar to ethereum-etl)Testing?
total_supplychanges (as expected)Notes from previous PR #64:
This commit is similar to the EIP-1559 pull request for ethereum-etl: blockchain-etl/ethereum-etl#256
The changes has been tested with
export_blocks_and_transactionscommand.I created separate pull requests for airflow and dataflow changes, so the deployment will be easier. Dependent PRs:
These pull requests will address this issue: #56
Fields added:
Note: There is one uncertain change about the postgres table. The file
cli/polygonetl/streaming/postgres_tables.pyis in the repo and I added new fields to it, but I can't find any table schema definition like this one for Ethereum. I am wondering ifpostgres_tables.pyis even used. Please point me to the schema definition files if they exist, and I will change them accordingly.Notes from previous PR #65
This change adds new fields introduced by EIP-1559 to airflow. This pull request depends on #64.
Reference changes for Ethereum:
Notes from previous PR #66
This change adds new fields introduced by EIP-1559 to dataflow module.
It has a dependency on #64.
Reference change for Ethereum: