Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade RPC methods #52

Merged
merged 26 commits into from
Nov 29, 2022
Merged

feat: Upgrade RPC methods #52

merged 26 commits into from
Nov 29, 2022

Conversation

andyv09
Copy link
Member

@andyv09 andyv09 commented Nov 17, 2022

Update RPC methods according to internal docs

@martines3000 martines3000 changed the title Feat: Upgrade RPC methods feat: Upgrade RPC methods Nov 17, 2022
Vid201
Vid201 previously approved these changes Nov 28, 2022
View reviewed changes
martines3000
martines3000 reviewed Nov 28, 2022
View reviewed changes
packages/snap/src/rpc/did/getAvailableMethods.ts Outdated Show resolved Hide resolved
packages/snap/src/rpc/did/switchMethod.ts Show resolved Hide resolved
packages/snap/src/utils/veramoUtils.ts Show resolved Hide resolved
packages/snap/src/utils/veramoUtils.ts Show resolved Hide resolved
packages/snap/src/utils/veramoUtils.ts Outdated Show resolved Hide resolved
martines3000
martines3000 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@martines3000 martines3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@martines3000 martines3000 merged commit 768a4f0 into develop Nov 29, 2022
@martines3000 martines3000 deleted the feat/update-vcstore-settings branch November 29, 2022 09:54
@github-actions github-actions bot mentioned this pull request Nov 29, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
This was referenced Feb 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martines3000 martines3000 martines3000 approved these changes

@Vid201 Vid201 Vid201 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyv09 @martines3000 @Vid201