fix(recurring buy): reconfigures how the frequency selection screen works by adding a new endpoint to check if payment method works for a particular frequency #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks by adding a new endpoint to check if payment method works for a particular frequency
blockdylanb
requested review from
dsisto-bc,
jjBlockchain,
milan-bc,
pedroapfilho,
plondon,
schnogz,
tbuchann and
TheLeoB
as code owners
schnogz
suggested changes
Aug 21, 2021
| // ONE_TIME is not a recurring buy option so take it out before displaying | ||
| const periods = Object.values(RecurringBuyPeriods) | ||
| const RowDisplay = ({ method, paymentInfo, period, setPeriod }: RowDisplayProps) => { | ||
| // ONE_TIME is a special case that we need to insert manually |
There was a problem hiding this comment.
can you expand on this comment for future us? when is ONE_TIME used and when is it not?
| ) : ( | ||
| <></> | ||
| )} | ||
| </> |
There was a problem hiding this comment.
do we need to return fragments on all of these? would null work?
| </FrequencyScreen> | ||
| ) | ||
| return data.cata({ | ||
| Failure: (error) => <>{error}</>, |
There was a problem hiding this comment.
should we style errors better?
| class Frequency extends PureComponent<Props> { | ||
| constructor(props) { | ||
| super(props) | ||
| this.handleFrequencySelection = this.handleFrequencySelection.bind(this) |
There was a problem hiding this comment.
should be able to delete this constructor. you shouldnt need to bind this when you define the function with a fat arrow
| @@ -43,8 +44,8 @@ class OrderSummary extends PureComponent<Props> { | |||
| // first time buyers have 1 tx at this point and RB is set to one time buy so send them to RB walkthrough flow | |||
| if ( | |||
| this.props.isRecurringBuy && | |||
| this.props.orders.length <= 1 && | |||
| this.props.order.period === RecurringBuyPeriods.ONE_TIME && | |||
| // this.props.orders.length <= 1 && | |||
feccruz
approved these changes
Aug 21, 2021
feccruz
approved these changes
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (optional)
Add a concise explanation of the changes.
Testing Steps (optional)
Detail the steps required for the reviewer(s) to verify and test these changes.