Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

chore(types): add Flow typing 🔥 ⚡ 🐸 #151

Merged
merged 1 commit into from
Oct 19, 2018
Merged

chore(types): add Flow typing 🔥 ⚡ 🐸 #151

merged 1 commit into from
Oct 19, 2018

Conversation

mpsq
Copy link
Contributor

@mpsq mpsq commented Oct 18, 2018

No description provided.

@mpsq mpsq removed the DO NOT MERGE label Oct 18, 2018
@mpsq mpsq changed the title chore(types): add flow to tools chore(types): add Flow typing 🔥 ⚡ 🐸 Oct 18, 2018
@blockfred
Copy link

build works 👌 - i get an error running storybook though:

$ yarn start
yarn run v1.10.1
$ start-storybook -p 6006
info @storybook/react v3.4.11
info
info => Loading custom .babelrc
info => Loading custom addons config.
info => Loading custom webpack config (extending mode).
webpack built 58f09192c00ec66c1e5b in 33546ms
Hash: 58f09192c00ec66c1e5b
Version: webpack 3.12.0
Time: 33546ms
                       Asset       Size  Chunks                    Chunk Names
    static/preview.bundle.js    6.37 MB       0  [emitted]  [big]  preview
    static/manager.bundle.js    2.95 MB       1  [emitted]  [big]  manager
static/preview.bundle.js.map    5.47 MB       0  [emitted]         preview
static/manager.bundle.js.map    3.61 MB       1  [emitted]         manager
                  index.html    1.21 kB          [emitted]
                 iframe.html  917 bytes          [emitted]
   [0] ./node_modules/react/index.js 190 bytes {0} {1} [built]
  [12] (webpack)/buildin/harmony-module.js 596 bytes {0} [built]
  [14] ./node_modules/@storybook/react/dist/client/index.js 1.79 kB {0} [built]
 [254] ./node_modules/@storybook/react/dist/server/config/polyfills.js 113 bytes {0} {1} [built]
 [677] multi ./node_modules/@storybook/react/dist/server/config/polyfills.js ./.storybook/addons.js ./node_modules/@storybook/core/dist/client/manager/index.js 52 bytes {1} [built]
 [678] ./.storybook/addons.js 133 bytes {1} [built]
 [711] ./node_modules/@storybook/core/dist/client/manager/index.js 423 bytes {1} [built]
 [968] multi ./node_modules/@storybook/react/dist/server/config/polyfills.js ./node_modules/@storybook/react/dist/server/config/globals.js (webpack)-hot-middleware/client.js?reload=true ./.storybook/config.js 64 bytes {0} [built]
 [969] ./node_modules/@storybook/react/dist/server/config/globals.js 105 bytes {0} [built]
 [970] (webpack)-hot-middleware/client.js?reload=true 7.77 kB {0} [built]
 [971] ./node_modules/querystring-es3/index.js 127 bytes {0} [built]
 [974] ./node_modules/strip-ansi/index.js 161 bytes {0} [built]
 [976] (webpack)-hot-middleware/client-overlay.js 2.21 kB {0} [built]
 [981] (webpack)-hot-middleware/process-update.js 4.37 kB {0} [built]
 [982] ./.storybook/config.js 834 bytes {0} [built]
    + 2954 hidden modules

ERROR in ./src/Atoms/Icons/withStyle.js
Module build failed: SyntaxError: /Users/fred/dev/blockchain/components/src/Atoms/Icons/withStyle.js: Support for the experimental syntax 'classProperties' isn't currently enabled (36:22):

  34 |   /* eslint-disable react/prefer-stateless-function */
  35 |   class WithStyle extends React.PureComponent<PropsType> {
> 36 |     static propTypes = {
     |                      ^
  37 |       selectable: PropTypes.bool,
  38 |       size: PropTypes.string,
  39 |     }

Add @babel/plugin-proposal-class-properties (https://git.io/vb4SL) to the 'plugins' section of your Babel config to enable transformation.
    at _class.raise (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:3939:15)
    at _class.expectPlugin (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:5253:18)
    at _class.parseClassProperty (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:8114:12)
    at _class.parseClassProperty (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:2270:55)
    at _class.pushClassProperty (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:8078:30)
    at _class.parseClassMemberWithIsStatic (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:8011:14)
    at _class.parseClassMember (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7948:10)
    at _class.parseClassBody (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7903:12)
    at _class.parseClass (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7853:10)
    at _class.parseStatementContent (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7181:21)
    at _class.parseStatement (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7153:17)
    at _class.parseStatement (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:1902:57)
    at _class.parseBlockOrModuleBlockBody (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7707:23)
    at _class.parseBlockBody (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7694:10)
    at _class.parseBlock (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:7683:10)
    at _class.parseFunctionBody (/Users/fred/dev/blockchain/components/node_modules/@babel/parser/lib/index.js:6933:24)
 @ ./src/Atoms/Icons/custom/bitcoin-cash.js 3:0-37
 @ ./src/Atoms/Icons/custom/index.js
 @ ./src/Atoms/Icons/index.js
 @ ./src/Atoms/Icons/custom.stories.js
 @ ./src stories\.js$
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/react/dist/server/config/polyfills.js ./node_modules/@storybook/react/dist/server/config/globals.js (webpack)-hot-middleware/client.js?reload=true ./.storybook/config.js

@mpsq
Copy link
Contributor Author

mpsq commented Oct 19, 2018

fixed

@tbuchann tbuchann merged commit 2e7fe7d into master Oct 19, 2018
@tbuchann tbuchann deleted the mp-flow branch October 19, 2018 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants