This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
refactor(input): correct checkbox logic for use with redux-form #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbuchann
requested review from
blockfred,
jtormey,
Lyncee59,
mpsq,
ncherence,
plondon,
prwelber,
schnogz,
thianh and
tony-blockchain
as code owners
mpsq
suggested changes
Feb 6, 2019
flow-typed/npm/redux-form_vx.x.x.js
Outdated
| touched: boolean, | ||
| valid: boolean, | ||
| value: string | boolean, | ||
| visited: boolean, |
|
Also, did you try to use the lib in a project which does not use/include |
tbuchann
force-pushed
the
refactor/checkbox
branch
3 times, most recently
from
d597c09
to
40052ba
Compare
|
Ha! Just realised that this libdef if very old (redux-form v5) and that it is deprecated. It is recommended to use the types directly from redux-form because that lib is typed with flow. We need to test that, bundle the lib and make sure that redux-form is not included. |
tbuchann
force-pushed
the
refactor/checkbox
branch
from
40052ba
to
886e3a8
Compare
mpsq
suggested changes
Feb 6, 2019
tbuchann
force-pushed
the
refactor/checkbox
branch
from
886e3a8
to
82dce0f
Compare
mpsq
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor checkbox logic to be used within
redux-form