Fix: Add null check for chain to secondary token balance flow (#1718)

* Add null check for secondaryTokenBals * Bump versions
blocknative · May 15, 2023 · 0483fb4 · 0483fb4
1 parent 690cb6f
commit 0483fb4
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/core",
-  "version": "2.18.0",
+  "version": "2.18.1-alpha.1",
   "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",

diff --git a/packages/core/src/update-balances.ts b/packages/core/src/update-balances.ts
@@ -43,6 +43,7 @@ export const updateSecondaryTokens = async (
   account: AccountAddress,
   chain: Chain
 ): Promise<SecondaryTokenBalances[]> => {
+  if (!chain) return
   const chainRPC = chain.rpcUrl
   if (!chain.secondaryTokens || !chain.secondaryTokens.length || !chainRPC)
     return

diff --git a/packages/core/src/views/connect/Index.svelte b/packages/core/src/views/connect/Index.svelte
@@ -341,6 +341,7 @@
       })
     }
     if (
+      appChain &&
       !secondaryTokens &&
       Array.isArray(appChain.secondaryTokens) &&
       appChain.secondaryTokens.length

diff --git a/packages/demo/package.json b/packages/demo/package.json
@@ -24,7 +24,7 @@
     "webpack-dev-server": "4.7.4"
   },
   "dependencies": {
-    "@web3-onboard/core": "^2.18.0",
+    "@web3-onboard/core": "^2.18.1-alpha.1",
     "@web3-onboard/coinbase": "^2.2.3",
     "@web3-onboard/transaction-preview": "^2.0.7",
     "@web3-onboard/dcent": "^2.2.6",

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/react",
-  "version": "2.8.2",
+  "version": "2.8.3-alpha.1",
   "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -62,7 +62,7 @@
     "typescript": "^4.5.5"
   },
   "dependencies": {
-    "@web3-onboard/core": "^2.18.0",
+    "@web3-onboard/core": "^2.18.1-alpha.1",
     "@web3-onboard/common": "^2.3.2",
     "use-sync-external-store": "1.0.0"
   },

diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/vue",
-  "version": "2.7.1",
+  "version": "2.7.2-alpha.1",
   "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -63,7 +63,7 @@
     "@vueuse/core": "^8.4.2",
     "@vueuse/rxjs": "^8.2.0",
     "@web3-onboard/common": "^2.3.2",
-    "@web3-onboard/core": "^2.18.0",
+    "@web3-onboard/core": "^2.18.1-alpha.1",
     "vue-demi": "^0.12.4"
   },
   "peerDependencies": {