Fix the connect modal getting covered by the bottom bar (#2057)

* fix the connect modal being covered by the bottom bar * pump the package version * feat: remove .mobile-safari class * bump packages' version * bump the version of @web3-onboard/core in other packages --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
blocknative · Mar 4, 2024 · ca2b510 · ca2b510
1 parent 5b52b93
commit ca2b510
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 19 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/core",
-  "version": "2.21.2",
+  "version": "2.21.3-alpha.1",
   "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",

diff --git a/packages/core/src/views/connect/Index.svelte b/packages/core/src/views/connect/Index.svelte
@@ -424,10 +424,6 @@
     scrollContainer && scrollContainer.scrollTo(0, 0)
   }
 
-  const isSafariMobile =
-    device.type === 'mobile' &&
-    device.browser.name &&
-    device.browser.name === 'Safari'
 </script>
 
 <style>
@@ -532,11 +528,6 @@
   .scroll-container::-webkit-scrollbar {
     display: none; /* Chrome, Safari and Opera */
   }
-  .mobile-safari {
-    /* Handles for Mobile Safari's floating Address Bar 
-    covering the bottom of the connect modal **/
-    padding-bottom: 80px;
-  }
 
   @media all and (min-width: 768px) {
     .container {
@@ -560,7 +551,7 @@
 
 {#if !autoSelect.disableModals}
   <Modal close={!connect.disableClose && close}>
-    <div class="container" class:mobile-safari={isSafariMobile}>
+    <div class="container">
       {#if connect.showSidebar}
         <Sidebar step={$modalStep$} />
       {/if}

diff --git a/packages/core/src/views/shared/Modal.svelte b/packages/core/src/views/shared/Modal.svelte
@@ -53,6 +53,7 @@
   .full-screen-background {
     width: 100vw;
     height: 100vh;
+    height: 100dvh;
   }
 
   .max-height {

diff --git a/packages/demo/package.json b/packages/demo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "demo",
-  "version": "2.0.9",
+  "version": "2.0.10",
   "devDependencies": {
     "assert": "^2.0.0",
     "browserify-zlib": "^0.2.0",
@@ -33,7 +33,7 @@
     "@web3-onboard/capsule": "2.0.1",
     "@web3-onboard/cede-store": "^2.2.0",
     "@web3-onboard/coinbase": "^2.2.6",
-    "@web3-onboard/core": "^2.21.2",
+    "@web3-onboard/core": "^2.21.3-alpha.1",
     "@web3-onboard/dcent": "^2.2.7",
     "@web3-onboard/enkrypt": "^2.0.3",
     "@web3-onboard/fortmatic": "^2.0.18",

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/react",
-  "version": "2.8.13",
+  "version": "2.8.14-alpha.1",
   "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -62,7 +62,7 @@
   },
   "dependencies": {
     "@web3-onboard/common": "^2.3.3",
-    "@web3-onboard/core": "^2.21.2",
+    "@web3-onboard/core": "^2.21.3-alpha.1",
     "use-sync-external-store": "1.0.0"
   },
   "peerDependencies": {

diff --git a/packages/solid/package.json b/packages/solid/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/solid",
-  "version": "2.0.0",
+  "version": "2.0.1-alpha.1",
   "description": "A collection of solid Composables for integrating Web3-Onboard in to a Solid project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -63,7 +63,7 @@
   },
   "dependencies": {
     "@web3-onboard/common": "^2.3.3",
-    "@web3-onboard/core": "^2.21.0",
+    "@web3-onboard/core": "^2.21.3-alpha.1",
     "solid-js": "^1.8.1"
   }
 }
diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/vue",
-  "version": "2.7.12",
+  "version": "2.7.13-alpha.1",
   "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -62,7 +62,7 @@
     "@vueuse/core": "^8.4.2",
     "@vueuse/rxjs": "^8.2.0",
     "@web3-onboard/common": "^2.3.3",
-    "@web3-onboard/core": "^2.21.2",
+    "@web3-onboard/core": "^2.21.3-alpha.1",
     "vue-demi": "^0.12.4"
   },
   "peerDependencies": {