Trust wallet integration & SDK #1463

karim-yassine · 2023-01-13T05:22:10Z

Hey web3-onboard team! I'm Karim, and I'm representing the Web Extension team of Trust Wallet. Based on Pull Request Guide, I'm opening this PR with a complete list of the changes it introduces (all related to Trust Wallet).

Description

Trust Wallet SDK package was created.
Not displaying Trust Wallet name and logo when wallet was injected fixed.
Conflicts between multiple injected wallets fixed.
Documentation with Trust Wallet examples added.

Checklist

The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
The box that allows repo maintainers to update this PR is checked
I tested locally to make sure this feature/fix works
I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
This PR passes the Circle CI checks

Tests with demo app (injected)

Tests with demo app (SDK)

QA (ongoing)

…let-integration-sdk

vercel · 2023-01-13T05:22:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
web3-onboard-docs	❌ Failed (Inspect)			Jan 27, 2023 at 5:37PM (UTC)

packages/trust/package.json

packages/trust/README.md

packages/trust/package.json

Adamj1232 · 2023-01-13T16:38:46Z

Thanks for putting this PR together @karim-yassine ! I left a few comments to address. Can you test and complete the new wallet injected and SDK checklist when you have a moment? Thanks! Looking forward to adding support!

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

karim-yassine · 2023-01-13T17:26:57Z

Hello @Adamj1232, all the changes suggested where committed!
Our QA team is working on testing the wallet integration; could you please approve the Vercel deployment workflow?
Thank you in advance!

Adamj1232 · 2023-01-13T17:48:02Z

@karim-yassine the vercel deployment is for our docs site we pulled into the develop branch. Please pull the latest develop when you have a chance.
For a vercel demo app of the Demo app for QA-ing wallet integration you will have to run yarn build within the demo package and then upload the public file from the demo package to vercel manually. We ill have this automated in the future.

…ion-sdk

Adamj1232 · 2023-01-26T16:10:48Z

@karim-yassine we are going to be putting together a release candidate today. Any chance this PR is ready for review? If not we will have a following release coming out next week (or the week after)

karim-yassine · 2023-01-27T12:08:49Z

@Adamj1232 Hello! I'll be opening PR today, we found a bug in the index of injected package that we fixed, I'm just finalizing testing and making sure that it works correctly with other wallets.

…let-integration-sdk

karim-yassine · 2023-01-27T15:23:14Z

@Adamj1232 ready for review.

Regarding our fix in the index file of injected package, the bug here was that the implementation assumed that if there is a provider array, that should only be checked, which is wrong because it excludes the global scope. For that reason we first check the global scope and then the providers array, if exist.

Adamj1232 · 2023-01-27T16:56:03Z

@karim-yassine thank you for the PR! I will test now!

Adamj1232

Thank you again for the PR and collaboration! Really appreciate it!

Adamj1232 · 2023-01-27T21:43:37Z

@karim-yassine If interested in doing a bit of co-marketing/tweeting on the new support and package please feel free to reach out 😃

* feat: intergration of SafePal wallet (#1450) * feat: intergration of SafePal wallet * cleanup Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update sdk version for TP (#1495) * Trust wallet integration & SDK (#1463) * feat: create trust wallet SDK * docs: add Trust wallet SDK docs link * docs: add trust SDK option * docs: add trust SDK option * chore: add trust SDK jobs * feat: add trust as part of the default wallets * feat: add trust type * fix: not identifying injected trust wallet * fix: building error * fix: only verify if trustwallet exists * fix: wallets conflicting with each other * chore: increment version * chore: revert version * docs: update documentation with Trust example * docs: update description Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * chore: update version Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * docs: resolve typo Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * fix: incorrectly checking providers * Add trust to docs site * Add docs and bump version * Fix deploy config --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Bump cookiejar from 2.1.3 to 2.1.4 (#1482) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cookiejar from 2.1.3 to 2.1.4 in /examples/with-vite-react (#1483) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cookiejar from 2.1.3 to 2.1.4 in /packages/demo (#1485) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cookiejar from 2.1.3 to 2.1.4 in /docs (#1486) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cookiejar from 2.1.3 to 2.1.4 in /examples/with-nextjs-13 (#1484) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Feat/add okx wallet (#1469) * feature: add okx wallet to injected * feature: add okx wallet to injected * feature: add okx wallet to injected * feature: add okx wallet to injected * feature: add okx wallet to injected * Update okx wallet usage * Add debugging code for okx team * Update svg for wallet * Clean up logs --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update versions for release * Address a couple of warnings from type-check * Bump sdk version in core --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: QiAbc <121917904+QiAbc@users.noreply.github.com> Co-authored-by: karim-yassine <118207693+karim-yassine@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: okxwallet <122091289+okxwallet@users.noreply.github.com>

atifnimran · 2023-03-30T10:33:02Z

Please ok

karim-yassine and others added 14 commits January 12, 2023 22:21

feat: create trust wallet SDK

9409b81

docs: add Trust wallet SDK docs link

4fa907b

docs: add trust SDK option

015afca

docs: add trust SDK option

a75d45d

chore: add trust SDK jobs

32ddd63

feat: add trust as part of the default wallets

50c392b

feat: add trust type

cb476fa

fix: not identifying injected trust wallet

594f5a4

Merge branch 'blocknative:v2-web3-onboard-develop' into fix/trust-wal…

894c968

…let-integration-sdk

fix: building error

2b36311

fix: only verify if trustwallet exists

5982c56

fix: wallets conflicting with each other

171627c

chore: increment version

4f2abb6

chore: revert version

023d2f8

vercel bot deployed to Preview January 13, 2023 05:24 View deployment

docs: update documentation with Trust example

bbfc201

vercel bot had a problem deploying to Preview January 13, 2023 15:54 Failure

Adamj1232 reviewed Jan 13, 2023

View reviewed changes

packages/trust/package.json Outdated Show resolved Hide resolved

Adamj1232 reviewed Jan 13, 2023

View reviewed changes

packages/trust/README.md Show resolved Hide resolved

Adamj1232 reviewed Jan 13, 2023

View reviewed changes

packages/trust/package.json Outdated Show resolved Hide resolved

Adamj1232 mentioned this pull request Jan 13, 2023

Added all platform support for injected Trust Wallet #1357

Closed

5 tasks

docs: update description

785b9d5

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

vercel bot had a problem deploying to Preview January 13, 2023 17:21 Failure

karim-yassine and others added 2 commits January 13, 2023 14:22

chore: update version

eece2f8

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

docs: resolve typo

f6ec3ec

Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>

vercel bot had a problem deploying to Preview January 13, 2023 17:23 Failure

vercel bot had a problem deploying to Preview January 24, 2023 13:19 Failure

Merge branch 'v2-web3-onboard-develop' into fix/trust-wallet-integrat…

b177dab

…ion-sdk

vercel bot had a problem deploying to Preview January 25, 2023 13:42 Failure

Merge branch 'v2-web3-onboard-develop' into fix/trust-wallet-integrat…

8dba7cd

…ion-sdk

vercel bot had a problem deploying to Preview January 26, 2023 12:53 Failure

fix: incorrectly checking providers

deb72ef

vercel bot had a problem deploying to Preview January 27, 2023 15:03 Failure

Merge branch 'blocknative:v2-web3-onboard-develop' into fix/trust-wal…

bbc7446

…let-integration-sdk

vercel bot had a problem deploying to Preview January 27, 2023 15:06 Failure

Add trust to docs site

7985905

vercel bot had a problem deploying to Preview January 27, 2023 17:08 Failure

Add docs and bump version

56fc9bb

vercel bot had a problem deploying to Preview January 27, 2023 17:17 Failure

Fix deploy config

495961e

vercel bot had a problem deploying to Preview January 27, 2023 17:37 Failure

Adamj1232 approved these changes Jan 27, 2023

View reviewed changes

Adamj1232 merged commit cd1ff27 into blocknative:v2-web3-onboard-develop Jan 27, 2023

This was referenced Jan 27, 2023

Release 2.19.1 (develop) #1496

Merged

Release 2.19.1 #1497

Merged

Release 2.19.1 (docs) #1498

Merged

This was referenced Aug 14, 2024

Release 2.27.0 #2269

Merged

Release 2.27.0 (develop) #2268

Merged

Release 2.27.0 (docs) #2270

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trust wallet integration & SDK #1463

Trust wallet integration & SDK #1463

karim-yassine commented Jan 13, 2023 •

edited by Adamj1232

Loading

vercel bot commented Jan 13, 2023 •

edited

Loading

Adamj1232 commented Jan 13, 2023

karim-yassine commented Jan 13, 2023

Adamj1232 commented Jan 13, 2023

Adamj1232 commented Jan 26, 2023

karim-yassine commented Jan 27, 2023

karim-yassine commented Jan 27, 2023

Adamj1232 commented Jan 27, 2023 •

edited

Loading

Adamj1232 left a comment

Adamj1232 commented Jan 27, 2023

atifnimran commented Mar 30, 2023

Trust wallet integration & SDK #1463

Trust wallet integration & SDK #1463

Conversation

karim-yassine commented Jan 13, 2023 • edited by Adamj1232 Loading

Description

Checklist

Tests with demo app (injected)

Tests with demo app (SDK)

vercel bot commented Jan 13, 2023 • edited Loading

Adamj1232 commented Jan 13, 2023

karim-yassine commented Jan 13, 2023

Adamj1232 commented Jan 13, 2023

Adamj1232 commented Jan 26, 2023

karim-yassine commented Jan 27, 2023

karim-yassine commented Jan 27, 2023

Adamj1232 commented Jan 27, 2023 • edited Loading

Adamj1232 left a comment

Choose a reason for hiding this comment

Adamj1232 commented Jan 27, 2023

atifnimran commented Mar 30, 2023

karim-yassine commented Jan 13, 2023 •

edited by Adamj1232

Loading

vercel bot commented Jan 13, 2023 •

edited

Loading

Adamj1232 commented Jan 27, 2023 •

edited

Loading