Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Vanilla js example #1643

Merged
merged 6 commits into from
Apr 17, 2023
Merged

Enhancement: Vanilla js example #1643

merged 6 commits into from
Apr 17, 2023

Conversation

leightkt
Copy link
Contributor

@leightkt leightkt commented Apr 14, 2023

Description

Vanilla js /webpack added to examples

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • [NA] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

@leightkt leightkt self-assigned this Apr 14, 2023
@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 10:00pm

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good!!

@leightkt leightkt merged commit 119e105 into develop Apr 17, 2023
@leightkt leightkt deleted the vanilla-js-example branch April 17, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants