Enhancement: Docs upgrade- kit-docs and sveltejs/kit #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leightkt
changed the title
Adamj1232
requested changes
Apr 28, 2023
|
@Adamj1232 realized I forgot to match the .prettierrc to the original version from the docs- updated and reformatted. Hopefully looks less wonky on the IDE now! LMK what you think! |
Adamj1232
reviewed
May 1, 2023
Adamj1232
reviewed
May 1, 2023
Adamj1232
reviewed
May 1, 2023
Adamj1232
reviewed
May 1, 2023
| @@ -1,4 +1,3 @@ | |||
| export * from './examples' | |||
| export * from './gas' | |||
| export { default as ThemeCustomizer } from './ThemeCustomizer.svelte' | |||
There was a problem hiding this comment.
Just curious why this is removed?
There was a problem hiding this comment.
It was moved directly to the +page.svelte file under the theming-tool folder- It would not load/build correctly otherwise.
Adamj1232
reviewed
May 1, 2023
| @@ -1 +0,0 @@ | |||
| export { Tabs, TabPanel, TabItem } from './tabs' | |||
There was a problem hiding this comment.
Do we still need this file or parent folder?
There was a problem hiding this comment.
yes to the parent folder (to be able to use Tabs in the .md files that are the docs pages), no to the index.ts file.
gesquinca
approved these changes
May 9, 2023
This was referenced May 11, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades:
@svelteness/kit-docs: 1.1.3
@sveltejs/kit: 1.5.0
Fixes font loading
Routes restructured to work with new kit-docs structure: https://kitdocs.vercel.app/docs/getting-started/quickstart
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errors