Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame connector #1700

Merged
merged 7 commits into from
May 10, 2023
Merged

Conversation

goosewobbler
Copy link
Contributor

Description

Adding full support for Frame

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) May 10, 2023 4:32pm

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
eth-provider@0.13.6 network, environment +4 cjm

@leightkt
Copy link
Contributor

@goosewobbler I was able to connect the wallet to the demo, sign transactions, and disconnect. I was not able to send a transaction on Goerli though- I get an error message: 'Connection for ethereum chain with chainId 5 did not exist for send',

Were you able to send a successful transaction?

README.md Show resolved Hide resolved
@goosewobbler
Copy link
Contributor Author

goosewobbler commented May 10, 2023

@leightkt Did you enable the Goerli chain in Frame? If you did then could be an RPC issue

@leightkt
Copy link
Contributor

@goosewobbler - that was it- needed to enable the chain. Looks good to go!

@goosewobbler
Copy link
Contributor Author

@leightkt Great. Do we need to do something else to fix the Vercel deployment?

packages/frame/package.json Outdated Show resolved Hide resolved
packages/frame/package.json Outdated Show resolved Hide resolved
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
@leightkt leightkt merged commit 2ba8d26 into blocknative:develop May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants