-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frame connector #1700
Add frame connector #1700
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
@goosewobbler I was able to connect the wallet to the demo, sign transactions, and disconnect. I was not able to send a transaction on Goerli though- I get an error message: 'Connection for ethereum chain with chainId 5 did not exist for send', Were you able to send a successful transaction? |
@leightkt Did you enable the Goerli chain in Frame? If you did then could be an RPC issue |
@goosewobbler - that was it- needed to enable the chain. Looks good to go! |
@leightkt Great. Do we need to do something else to fix the Vercel deployment? |
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Description
Adding full support for Frame
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errorsDocs Checklist
docs/package.json
file (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Tests with demo app (injected)
Tests with demo app (SDK)